Small log collection refactor to prepare catching fw errors #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preempts any confusion with kernel or other logs files. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Add a new clogfile=$1 parameter to func_mtrace_collect() to make it consistent with the older func_sof_logger_collect() and define all logfile names in the same place. Also log the logfile name and stop abusing bash leniency that has let us treat and expand $mtraceCmd like an array even if it's not. Fixes initial commit c0729e8 ("Enable mtrace") which merely copied the logging code from the other func_sof_logger_collect() function which does use an array. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Now that $logfile is defined for mtrace too, run the same check on it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
fredoh9
approved these changes
Jun 30, 2023
Contributor
There was a problem hiding this comment.
Looks good. Approved.
One curious thing, I checked the results, one of failure in MTL test. mtrace lines is 178 but nlines=176. Not a big deal but looks first and last lines are NOT new lines?
reference link: planresultdetail/28427?model=MTLP_RVP_NOCODEC&testcase=check-suspend-resume-with-capture-5
greg-intel
approved these changes
Jun 30, 2023
Collaborator
Author
|
thanks for the very prompt reviews!
There is probably something funny the web interface does. The number comes from a bare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits
Preparation for #1075, only one small functional change: counting the number of lines in mtrace.txt