Skip to content

Conversation

@plbossart
Copy link
Member

First step to remove use of kernel parameters

Link: thesofproject/linux#4902
Link: #1166

@plbossart plbossart requested a review from a team as a code owner April 3, 2024 19:45
@plbossart
Copy link
Member Author

shellcheck error is a pre-existing issue that was obviously overlooked

In case-lib/lib.sh line 954:
        TGLU_RVP_NOCODEC_IPC4ZPH | ADLP_RVP_NOCODEC_IPC4ZPH | MTLP_RVP_NOCODEC |ADLP_RVP_NOCODEC-ipc4 | TGLU_RVP_NOCODEC-ipc4 | MTLP_RVP_NOCODEC | MTLP_RVP_NOCODEC-multicore-2cores | MTLP_RVP_NOCODEC-multicore-3cores | LNLM_RVP_NOCODEC)
                                                              ^--------------^ SC22[21](https://github.com/thesofproject/sof-test/actions/runs/8544615585/job/23411051491?pr=1167#step:3:22) (warning): This pattern always overrides a later one on line 954.
                                                                                                                                ^--------------^ SC[22](https://github.com/thesofproject/sof-test/actions/runs/8544615585/job/23411051491?pr=1167#step:3:23)22 (warning): This pattern never matches because of a previous pattern on line 954.

MTLP_RVP_NOCODEC is listed twice in the same OR.

marc-hb
marc-hb previously requested changes Apr 3, 2024
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc:

    # If /sys/module/snd_sof_pci/parameters/ipc_type does not exist
    # the DUT is running IPC3 mode

This shortcut and bad assumption should print a big fat dlogw() TODAY and be "upgraded" to a die() failure in the future. Please add the dlogw() now; I think that would have saved you time and it will save others'

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 4, 2024

MTLP_RVP_NOCODEC is listed twice in the same OR.

(Unrelated) fix submitted in #1168. Now merged.

@plbossart plbossart force-pushed the ipc4-fixes branch 2 times, most recently from 7e3fc59 to 7423c19 Compare April 4, 2024 20:02
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for some nits and one... missing fi?

@marc-hb marc-hb requested a review from ssavati April 4, 2024 23:51
@marc-hb marc-hb dismissed their stale review April 5, 2024 00:03

stale request for changes

First step to remove use of kernel parameters

Link: thesofproject/linux#4902
Link: thesofproject#1166

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
prefer the use of the debugfs information to the kernel parameter.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Dump kernel parameters AND debugfs fw_profile

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
No functionality change

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 5, 2024

Lots of models missing but everything green for the ones present

@marc-hb marc-hb merged commit 74bcaa5 into thesofproject:main Apr 8, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 9, 2024

This does not work actually: it's at least missing a few sudo. I think you didn't notice because you run sof-test as root but that's not how it's usually tested.

https://sof-ci.01.org/softestpr/PR1167/build265/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=verify-kernel-module-load-probe

2024-04-05 14:58:59 UTC [REMOTE_INFO] Starting func_exit_handler(0)
cat: /sys/kernel/debug/sof/fw_profile/ipc_type: Permission denied
2024-04-05 14:58:59 UTC [REMOTE_WARNING] using pre kernel 6.9 backwards-compatible fallback with ipc_type kernel parameter
cat: /sys/kernel/debug/sof/fw_profile/ipc_type: Permission denied
2024-04-05 14:58:59 UTC [REMOTE_WARNING] using pre kernel 6.9 backwards-compatible fallback with ipc_type kernel parameter
2024-04-05 14:58:59 UTC [REMOTE_INFO] pkill -TERM -f mtrace-reader.py
2024-04-05 14:58:59 UTC [REMOTE_INFO] ktime=123 sof-test PID=3129: ending
2024-04-05 14:58:59 UTC [REMOTE_INFO] Test Result: PASS!

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants