-
Notifications
You must be signed in to change notification settings - Fork 59
case-lib: is_ipc4: use new debugfs file instead of kernel parameter #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
shellcheck error is a pre-existing issue that was obviously overlooked MTLP_RVP_NOCODEC is listed twice in the same OR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc:
# If /sys/module/snd_sof_pci/parameters/ipc_type does not exist
# the DUT is running IPC3 mode
This shortcut and bad assumption should print a big fat dlogw() TODAY and be "upgraded" to a die() failure in the future. Please add the dlogw() now; I think that would have saved you time and it will save others'
(Unrelated) fix submitted in #1168. Now merged. |
7e3fc59 to
7423c19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for some nits and one... missing fi?
First step to remove use of kernel parameters Link: thesofproject/linux#4902 Link: thesofproject#1166 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
prefer the use of the debugfs information to the kernel parameter. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Dump kernel parameters AND debugfs fw_profile Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
No functionality change Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
Lots of models missing but everything green for the ones present |
|
This does not work actually: it's at least missing a few |
|
Filed new issue: |
First step to remove use of kernel parameters
Link: thesofproject/linux#4902
Link: #1166