LNLM_SDW_AIOC.sh: overrides the headset detected_mode #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
May 8, 2024
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Is this not going to fail without thesofproject/linux#4969 ?
We want to keep a reasonable amount of backwards compatibility.
marc-hb
reviewed
May 8, 2024
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Also: add a comment with the URL. Without context it's impossible to guess why this is done.
fredoh9
force-pushed
the
fix/lnl_sdw_aioc_headset_mode
branch
from
0ef13de to
35751d7
Compare
marc-hb
previously approved these changes
May 8, 2024
bardliao
previously approved these changes
May 9, 2024
plbossart
reviewed
May 9, 2024
LNL RVP keep toggling between headphone and headset. Overrides to headset only for the test. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
fredoh9
force-pushed
the
fix/lnl_sdw_aioc_headset_mode
branch
from
35751d7 to
ac6a188
Compare
marc-hb
approved these changes
May 9, 2024
plbossart
approved these changes
May 9, 2024
bardliao
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LNL RVP keep toggling between headphone and headset. Overrides to headset only for the test.
Related kernel PR: thesofproject/linux#4969