check-sof-logger.sh Predicate LDC search on !zephyr #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephyr builds don't produce .ldc files anymore, don't look for them and fail. Fixes: thesofproject#1216 Signed-off-by: Andy Ross <andyross@google.com>
Contributor
Author
marc-hb
approved these changes
Jul 9, 2024
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Test results look good!
Thanks a lot, I was afraid it would be more complicated (this script is very convoluted in other places) but this seems enough, great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I haven't completely figured out how this script runs in CI, so this patch is mostly thrown up blind for review. But this is where the error in CI is coming from, I believe]
Zephyr builds don't produce .ldc files anymore, don't look for them and fail.
Fixes: #1216