Skip to content

Conversation

@Bin-QA
Copy link
Contributor

@Bin-QA Bin-QA commented Jan 3, 2020

Add new test Case for the suspend resume

Signed-off-by: Wu, BinX binx.wu@intel.com

@Bin-QA
Copy link
Contributor Author

Bin-QA commented Jan 6, 2020

@libinyang @keqiaozhang @xiulipan @aiChaoSONG
please help to review this case, current know issue: #16

Copy link
Contributor

@xiulipan xiulipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bin-QA Please rename the test case into suspend/resume, for some platform we will need to run in deep(s3) and for some platform we would like to run in s2idle(s0ix). But we would to let the device to run on the default setting.

So please keep the args for the suspend/resume type, but only overwrite when we want, we should output what type we are running.

@Bin-QA Bin-QA changed the title Test Case: Add check S3 test Test Case: Add check suspend resume test Jan 6, 2020
Copy link
Contributor

@xiulipan xiulipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some simple issue with commit spilt and variable naming.
I think we need to only override the power mode when we want and keep the default value as it is.

@xiulipan
Copy link
Contributor

xiulipan commented Jan 6, 2020

@Bin-QA @keqiaozhang @libinyang So here I think we will keep the behavior to be

  • use default mode to do test if no argument is passed.
  • override the mode with the argument

@keqiaozhang
Copy link
Contributor

@xiulipan Agree, use deep as default and override it if it's specified.

Add new Test Case for the suspend resume

Signed-off-by: Wu, BinX <binx.wu@intel.com>
@stripes416
Copy link
Contributor

I'm currently running the manual suspend-resume tests on ICL --- this looks good to me & I can't think of anything to add to the code. Good job @Bin-QA

Copy link
Contributor

@xiulipan xiulipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiulipan xiulipan merged commit 606d849 into thesofproject:master Jan 9, 2020
@Bin-QA Bin-QA deleted the S3 branch January 22, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants