-
Notifications
You must be signed in to change notification settings - Fork 59
Test Case: Add check suspend resume test #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@libinyang @keqiaozhang @xiulipan @aiChaoSONG |
xiulipan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bin-QA Please rename the test case into suspend/resume, for some platform we will need to run in deep(s3) and for some platform we would like to run in s2idle(s0ix). But we would to let the device to run on the default setting.
So please keep the args for the suspend/resume type, but only overwrite when we want, we should output what type we are running.
xiulipan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some simple issue with commit spilt and variable naming.
I think we need to only override the power mode when we want and keep the default value as it is.
|
@Bin-QA @keqiaozhang @libinyang So here I think we will keep the behavior to be
|
|
@xiulipan Agree, use deep as default and override it if it's specified. |
Add new Test Case for the suspend resume Signed-off-by: Wu, BinX <binx.wu@intel.com>
|
I'm currently running the manual suspend-resume tests on ICL --- this looks good to me & I can't think of anything to add to the code. Good job @Bin-QA |
xiulipan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add new test Case for the suspend resume
Signed-off-by: Wu, BinX binx.wu@intel.com