case-lib: hijack.sh fix trap exit command #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
direct to `trap 'func' exit` command will load the exit code of exit command use `trap 'func $?' exit` to passdown exit code to the function Signed-off-by: Wu, BinX <binx.wu@intel.com>
|
As we lost exit code without this patch, test case is highly impacted, I will merge this. |
Collaborator
|
Could you also do this? A default value doesn't make sense anymore, --- a/case-lib/hijack.sh
+++ b/case-lib/hijack.sh
@@ -6,7 +6,7 @@ trap 'func_exit_handler $?' EXIT
# Overwrite other functions' exit to perform environment cleanup
function func_exit_handler()
{
- local exit_status=${1:-0}
+ local exit_status="$1"
# when sof logger collect is open
if [ "X$SOF_LOG_COLLECT" == "X1" ]; then |
Contributor
Author
|
@marc-hb yes, it looks have some gap with original design, you also can submit the PR to fix it :) |
Collaborator
I don't submit without testing, what is the easiest way to test this particular code locally? I see @plbossart filed a number of usability issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
direct to
trap 'func' exitcommandwill load the exit code of exit command
use
trap 'func $?' exitto passdown exit codeto the function
Signed-off-by: Wu, BinX binx.wu@intel.com