[DON't MERGE] check-ipc-flood.sh: check ipc flood test logs from dmesg #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure IPC flood test results are printed. If the test summary is not available, it is failed case. This is a fix of false positive case. [ 96.248808] sof-audio-pci 0000:00:1f.3: error: debugfs write failed to idle -16 Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
fredoh9
changed the title
Contributor
Author
|
Checking logs may not be good idea. It may not come if debug level is not verbose. I will debug why dmesg 'error' didn't lead to test failure. |
Contributor
Author
|
Looks this error is known false alarm, added to ignoring messages. https://github.com/thesofproject/sof-test/blob/master/tools/sof-kernel-log-check.sh#L6
|
Collaborator
Ignoring errors is very dangerous and should be carefully reviewed and extensively documented. At the very least this code should be changed to something like: # because blabla, see bug 1234
ignore_str="$ignore_str"'|error: debugfs write failed to idle -16'
# because blabla, see bug 5678
ignore_str="$ignore_str"'|error: status'@xiulipan , @aiChaoSONG and @Bin-QA please help. EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure IPC flood test results are printed. If the test summary is not
available, it is failed case. This is a fix of false positive case.
[ 96.248808] sof-audio-pci 0000:00:1f.3: error: debugfs write failed to idle -16
Signed-off-by: Fred Oh fred.oh@linux.intel.com
Related issue is thesofproject/linux#2204
I will debug why ipc flood test is not performed and failed to transit to idle.