-
Notifications
You must be signed in to change notification settings - Fork 59
Include errors outside sof-audio before scanning dmesg for errors, ignore only specific known issues #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include errors outside sof-audio before scanning dmesg for errors, ignore only specific known issues #290
Conversation
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shellcheck warnings seem to all make sense.
Later we should drop such "screen scraping" and use something more robust like |
f5d184d to
d5282c7
Compare
This is good idea, I will create an issue to follow up. |
Scan all dmesg without filtering any word. Unrelevant errors should be ignored by adding error phases to 'ignore_str'. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Realtek codecs thrown an error on startup, need to ignore this error for now. kernel: [ 759.001903] rt700 sdw:1:25d:700:0: Parity error detected Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Known usb issue in CML Helios platform. This is nothing to do with SOF project. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @xiulipan - this would be a perfect use case for sof-test CI.
aiChaoSONG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. LGTM
When scan errors in kernel log in sof-kernel-log-check.sh, current code filter "sof-audio" first then check for error. This will limit scanning logs and not scalable. Below $project_key is nothing but "sof-audio".
We should remove this limitation. If we see unrelated error, we can add it to ignoring error list. This is first step toward this approach. I ran first test on APL, CML Helios, ICL RVP. If no objection is raised, I will scan logs for all supported platforms and update ignore_str.