hijack.sh: fix sudo test for cached credentials or NOPASSWD #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my system sudo fails to use cached credentials when invoked from "expect" for some unknown reason. Rather than debugging this, let's replace the 9 lines long expect test with a much simpler one-line "sudo --non-interactive" test which works perfectly. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Contributor
Collaborator
Author
|
I'm not sure I understand the scope of #370 . In the mean time can you please review this? It merely replaces a complex, 9 lines-long expect script that doesn't work with a dead simple one-line |
xiulipan
suggested changes
Sep 9, 2020
Contributor
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
Some simple question here, do we need to exit 1 here?
|
|
||
| # Test for either cached credentials or NOPASSWD | ||
| if $SUDO_CMD --non-interactive true | ||
| then |
Contributor
There was a problem hiding this comment.
Do we need else here to exit 1?
Collaborator
Author
There was a problem hiding this comment.
The exit I removed were expect commands, not shell commands.
xiulipan
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system sudo fails to use cached credentials when invoked from
"expect" for some unknown reason. Rather than debugging this, let's
replace the 9 lines long
expecttest with a much simpler one-line "sudo--non-interactive" test which works perfectly.
Signed-off-by: Marc Herbert marc.herbert@intel.com