Make func_lib_check_sudo() a warning cause sudo() message is better #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The fix for the single shellcheck warning in https://travis-ci.org/github/thesofproject/sof-test/builds/725414147 was already submitted in #361 |
Collaborator
Author
|
The only failure device-test failure in https://sof-ci.01.org/softestpr/PR369/build164/devicetest is ICL issue #365 |
See long comment in the function header. Also remove very bad SUDO_PASSWD suggestion from the error message and replace it with less insecure NOPASSWD and cache credentials suggestions. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
sudo-warning
branch
from
c38f1d0 to
6c991b5
Compare
Collaborator
Author
|
Pure rebase, no code change. |
xiulipan
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See long comment in the function header.
Also remove very bad SUDO_PASSWD suggestion from the error message and
replace it with less insecure NOPASSWD and cache credentials
suggestions.
Signed-off-by: Marc Herbert marc.herbert@intel.com