Skip to content

Conversation

@RuiqingX
Copy link
Contributor

test-case: add set -e to 5 function test

Fixes: #312

Signed-off-by: RuiqingX ruiqingx.zhang@intel.com

Fixes: thesofproject#312

Signed-off-by: RuiqingX <ruiqingx.zhang@intel.com>
@RuiqingX RuiqingX requested a review from a team as a code owner September 21, 2020 07:46
@RuiqingX
Copy link
Contributor Author

SOFCI TEST

@xiulipan
Copy link
Contributor

@RuiqingX I think some case may not be able to run with set -e. Please try with case by case locally first.

@RuiqingX RuiqingX closed this Sep 23, 2020
@aiChaoSONG
Copy link

@RuiqingX Next time when you want to close an issue or a PR, please give some reason.

Ruiqing tested that directly adding set -e to 7 cases will not cause any problem, he will submit a new PR with that changes to that 7 cases. @RuiqingX Can you list the script names which set -e will cause problems?

@RuiqingX
Copy link
Contributor Author

These scripts will have problems after adding set -e:
check-xrun-injection.sh
multiple-pipeline-playback.sh
multiple-pipeline-capture.sh
test-speaker.sh
check-pause-release-suspend-resume.sh
check-sof-logger.sh
check-signal-stop-start.sh
check-runtime-pm-status.sh
check-runtime-pm-double-active.sh
verify-ucm-config.sh
simultaneous-playback-capture.sh

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 23, 2020

Thanks @RuiqingX , if you're not sure how to make a script compatible with set -e then feel free to contact me and I will help.

A good start for any script is to fix shellcheck warnings first.

One script at a time to minimize any unexpected CI impact.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 23, 2020

Newer PR with a couple scripts from this list + other scripts: #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sof-test] add set -e to all test cases (Unless You Love Debugging)

4 participants