Tools: Fix for printing extra blank after value #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The just display value option "-v or --value" for sof-tplgreader.py outputs after the actual value a space character. It can cause unexpected issues when utilizing the values in test scripts. The added strip fixes the issue. Fixes thesofproject#408 Signed-off-by: Marc Herbert <marc.herbert@intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
marc-hb
approved these changes
Oct 9, 2020
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
After looking around in sof-test, I think the reason no one needed this before is because the noKey option is never used. It's always key=value; + eval instead. If correct this also means this PR cannot break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The just display value option "-v or --value" for sof-tplgreader.py
outputs after the actual value a space character. It can cause
unexpected issues when utilizing the values in test scripts. The added
strip fixes the issue.
Fixes #408
Signed-off-by: Marc Herbert marc.herbert@intel.com
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com