sof-kernel-log-check.sh: change sed -n $begin,\$p to tail -n +$begin #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiulipan
suggested changes
Oct 15, 2020
Contributor
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
I think declare -p will output some debug logs. You can keep it as comment out to help developer to debug later but I do not think we should enable it by default.
2020-10-14 06:19:16 UTC [REMOTE_INFO] Check sof debug fs environment
2020-10-14 06:19:16 UTC [REMOTE_INFO] Checking ipc flood test!
2020-10-14 06:19:16 UTC [REMOTE_INFO] ===== [1/1] loop Begin =====
2020-10-14 06:19:16 UTC [REMOTE_COMMAND] sudo bash -c 'echo 10000 > /sys/kernel/debug/sof/ipc_flood_count'
declare -- cmd="dmesg"
2020-10-14 06:19:17 UTC [REMOTE_INFO] Dumping test logs!
[ 101.921335] sof-audio-pci 0000:00:1f.3: IPC Flood count: 10000, Avg response time: 53016ns
[ 101.921335] sof-audio-pci 0000:00:1f.3: Max response time: 123315ns
[ 101.921336] sof-audio-pci 0000:00:1f.3: Min response time: 36133ns
declare -- cmd="tail -n +1283 /var/log/kern.log"
2020-10-14 06:19:17 UTC [REMOTE_INFO] Test Result: PASS!
This allows removing "eval" and some quoting headaches. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This file gets frequent updates because of the (relatively) new ignore_str. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
I agree except we have already found issues! see #366, your commit 8b1092e, #354 (comment) and probably others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removing "eval" and some quoting headaches.
Also fix the last shellcheck warnings