Skip to content

multiple-pipeline: replace pidof->ps to catch uninterruptible sleep #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiulipan merged 2 commits into from
Dec 2, 2020
Merged

multiple-pipeline: replace pidof->ps to catch uninterruptible sleep #538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b031922
multiple-pipeline: explicit tmp_count initialization
marc-hb Dec 1, 2020
d56e0b9
multiple-pipeline: replace pidof->ps to catch uninterruptible sleep
marc-hb Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 29 additions & 31 deletions test-case/multiple-pipeline.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ DEV_LST['playback']='/dev/zero'
APP_LST['capture']='arecord_opts'
DEV_LST['capture']='/dev/null'

tmp_count=$max_count

# define for load pipeline
func_run_pipeline_with_type()
{
Expand Down Expand Up @@ -107,6 +105,27 @@ func_error_exit()
exit 1
}


ps_checks()
{
local play_count rec_count total_count
# Extra logging
# >&2 ps u --no-headers -C aplay -C arecord || true

rec_count=$(ps --no-headers -C arecord | wc -l)
play_count=$(ps --no-headers -C aplay | wc -l)
total_count=$((rec_count + play_count))

[ "$total_count" -eq "$max_count" ] ||
func_error_exit "Target pipeline count: $max_count, current process count: $total_count"

[ "$rec_count" = 0 ] || sof-process-state.sh arecord >/dev/null ||
func_error_exit "Caught abnormal process status of arecord"
[ "$play_count" = 0 ] || sof-process-state.sh aplay >/dev/null ||
func_error_exit "Caught abnormal process status of aplay"
}


for i in $(seq 1 $loop_cnt)
do
# set up checkpoint for each iteration
Expand All @@ -117,56 +136,35 @@ do
f_arg=${OPT_VALUE_lst['f']}
case "$f_arg" in
'p')
tmp_count=$max_count
func_run_pipeline_with_type "playback"
func_run_pipeline_with_type "capture"
;;
'c')
tmp_count=$max_count
func_run_pipeline_with_type "capture"
func_run_pipeline_with_type "playback"
;;
*)
die "Wrong -f argument $f_arg, see -h"
esac

dlogi "pipeline start sleep 0.5s for device wakeup"
dlogi "sleep ${OPT_VALUE_lst['w']}s for sound device wakeup"
sleep ${OPT_VALUE_lst['w']}

# check all refer capture pipeline status
# 1. check process count:
rec_count=$(pidof arecord|wc -w)
tmp_count=$((tmp_count + rec_count))
play_count=$(pidof aplay|wc -w)
tmp_count=$((tmp_count + play_count))
[[ $tmp_count -ne $max_count ]] && func_error_exit "Target pipeline count: $max_count, current process count: $tmp_count"

# 2. check arecord process status
dlogi "checking pipeline status"
[ "$rec_count" = 0 ] || sof-process-state.sh arecord >/dev/null ||
func_error_exit "Catch the abnormal process status of arecord"
[ "$play_count" = 0 ] || sof-process-state.sh aplay >/dev/null ||
func_error_exit "Catch the abnormal process status of aplay"
ps_checks

dlogi "preparing sleep ${OPT_VALUE_lst['w']}"
sleep ${OPT_VALUE_lst['w']}

# 3. check process count again:
tmp_count=0
rec_count=$(pidof arecord|wc -w)
tmp_count=$((tmp_count + rec_count))
play_count=$(pidof aplay|wc -w)
tmp_count=$((tmp_count + play_count))
[[ $tmp_count -ne $max_count ]] && func_error_exit "Target pipeline count: $max_count, current process count: $tmp_count"

# 4. check arecord process status
# check processes again
dlogi "checking pipeline status again"
[ "$rec_count" = 0 ] || sof-process-state.sh arecord >/dev/null ||
func_error_exit "Catch the abnormal process status of arecord"
[ "$play_count" = 0 ] || sof-process-state.sh aplay >/dev/null ||
func_error_exit "Catch the abnormal process status of aplay"
ps_checks

dlogc 'pkill -9 aplay arecord'
[ "$rec_count" = 0 ] || pkill -9 arecord
[ "$play_count" = 0 ] || pkill -9 aplay
pkill -9 arecord || true
pkill -9 aplay || true

# check kernel log for each iteration to catch issues
sof-kernel-log-check.sh "$KERNEL_CHECKPOINT" || die "Caught error in kernel log"
Expand Down