sof-test: use journalctl for log collection #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
SOFCI TEST |
Previously, we will use /var/log/kern.log for log collcetion.
At the beginning of a test, we set up DMESG_LOG_START_LINE,
and at the end of the test, we collect kernel log from the
exact point we set up.
However, /var/log/kern.log is not exist on other distro. This
patch discards the existing log collection mechanism, and use
journalctl for log collection.
The changes include:
- lib.sh: remove implicit setup of DMESG_LOG_START_LINE
- hijack.sh: use journalctl to replace /var/log/kern.log
for log collection.
- test-case: test case fix as we need explicitly set up
kernel check point for journalctl.
Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
force-pushed
the
use_journalctl
branch
from
afea4bb to
5021617
Compare
keqiaozhang
approved these changes
Apr 19, 2021
Author
|
With all marc's review addressed, and failure not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EDIT: this is a later version of #639 , where the code review happened]
Previously, we will use /var/log/kern.log for log collcetion.
At the beginning of a test, we set up DMESG_LOG_START_LINE,
and at the end of the test, we collect kernel log from the
exact point we set up.
However, /var/log/kern.log is not exist on other distro. This
patch discards the existing log collection mechanism, and use
journalctl for log collection.
The changes include:
for log collection.
kernel check point for journalctl.
Signed-off-by: Chao Song chao.song@linux.intel.com