Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 28, 2021

This reverts commit f93a3c8.

This broke multiple-pipeline-playback-50 on sh-tglu-sku0a3e-sdw-01 and
jf-cml-sku0983-sdw-2, see below. Almost all other platforms ran
fine.

Found by Keqiao in daily test run 3577 (thx)

It's not clear what exactly the issue/race is yet (let's discuss in
original PR #543 or in a new bug linked from there) but the top
priority is to fix the tests.

2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: Speaker [hw:0,2]
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,2 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: HDMI 1 [hw:0,5]
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,5 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: HDMI 2 [hw:0,6]
2021-04-27 22:35:17 UTC [REMOTE_INFO] checking pipeline status
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,6 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Letting playback/capture run for 5s
2021-04-27 22:35:22 UTC [REMOTE_INFO] checking pipeline status again
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] pkill -9 aplay arecord
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59208 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59216 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59190 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
declare -- cmd="journalctl_cmd --since=@1619562912"

2021-04-27 22:35:22 UTC [REMOTE_INFO] ===== Testing: (Loop: 2/50) =====

2021-04-27 22:35:22 UTC [REMOTE_INFO] /home/ubuntu/sof-test/test-case/multiple-pipeline.sh will use topology /lib/firmware/intel/sof-tplg/sof-tgl-rt715-rt711-rt1308-mono.tplg to run the test case
2021-04-27 22:35:22 UTC [REMOTE_INFO] Pipeline list to ignore is specified, will ignore 'pcm=HDA Digital' in test case
2021-04-27 22:35:22 UTC [REMOTE_INFO] Run command to get pipeline parameters
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] sof-tplgreader.py /lib/firmware/intel/sof-tplg/sof-tgl-rt715-rt711-rt1308-mono.tplg -f 'type:playback' -b ' pcm:HDA Digital' -s 0 -e
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: Jack Out [hw:0,0]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: Speaker [hw:0,2]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,2 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: HDMI 1 [hw:0,5]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,5 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: HDMI 2 [hw:0,6]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,6 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] checking pipeline status
2021-04-27 22:35:22 UTC [REMOTE_ERROR] Running process count is 5, but 4 is expected

…eep"

This reverts commit f93a3c8.

This broke multiple-pipeline-playback-50 on sh-tglu-sku0a3e-sdw-01 and
jf-cml-sku0983-sdw-2, see below. Almost all other platforms ran
fine.

Found by Keqiao in daily test run 3577 (thx)

It's not clear what exactly the issue/race is yet (let's discuss in
original PR thesofproject#543 or in a new bug linked from there) but the top
priority is to fix the tests.

```
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: Speaker [hw:0,2]
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,2 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: HDMI 1 [hw:0,5]
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,5 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Testing: HDMI 2 [hw:0,6]
2021-04-27 22:35:17 UTC [REMOTE_INFO] checking pipeline status
2021-04-27 22:35:17 UTC [REMOTE_COMMAND] aplay   -D hw:0,6 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:17 UTC [REMOTE_INFO] Letting playback/capture run for 5s
2021-04-27 22:35:22 UTC [REMOTE_INFO] checking pipeline status again
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] pkill -9 aplay arecord
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59208 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59216 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
/home/ubuntu/sof-test/test-case/../case-lib/lib.sh: line 312: 59190 Killed                  aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
declare -- cmd="journalctl_cmd --since=@1619562912"

2021-04-27 22:35:22 UTC [REMOTE_INFO] ===== Testing: (Loop: 2/50) =====

2021-04-27 22:35:22 UTC [REMOTE_INFO] /home/ubuntu/sof-test/test-case/multiple-pipeline.sh will use topology /lib/firmware/intel/sof-tplg/sof-tgl-rt715-rt711-rt1308-mono.tplg to run the test case
2021-04-27 22:35:22 UTC [REMOTE_INFO] Pipeline list to ignore is specified, will ignore 'pcm=HDA Digital' in test case
2021-04-27 22:35:22 UTC [REMOTE_INFO] Run command to get pipeline parameters
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] sof-tplgreader.py /lib/firmware/intel/sof-tplg/sof-tgl-rt715-rt711-rt1308-mono.tplg -f 'type:playback' -b ' pcm:HDA Digital' -s 0 -e
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: Jack Out [hw:0,0]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: Speaker [hw:0,2]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,2 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: HDMI 1 [hw:0,5]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,5 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] Testing: HDMI 2 [hw:0,6]
2021-04-27 22:35:22 UTC [REMOTE_COMMAND] aplay   -D hw:0,6 -c 2 -r 48000 -f S16_LE /dev/zero -q
2021-04-27 22:35:22 UTC [REMOTE_INFO] checking pipeline status
2021-04-27 22:35:22 UTC [REMOTE_ERROR] Running process count is 5, but 4 is expected
```
@marc-hb marc-hb requested a review from a team as a code owner April 28, 2021 18:29
@plbossart
Copy link
Member

thanks @marc-hb I was wondering what caused these bugs, I didn't think of sof-test.

@marc-hb marc-hb merged commit 4173e84 into thesofproject:main Apr 28, 2021
@marc-hb marc-hb deleted the revert-multi-sleep branch April 28, 2021 19:41
@aiChaoSONG
Copy link

@marc-hb Without the sleep, the aplay(s) started in the first iteration is not fully killed in the second iteration, wait some time before all aplay(s) disappear from ps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants