multiple-pipeline: simplify sleeps #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the same -w parameter for two different sleeps in the same iteration made no sense. It was not clear what the purpose of this first sleep was, it has been in multiple-pipeline-capture/playback.sh since the dawn of time (= commit 39cd964) For sure this first sleep was helping hide "uninterruptible state" bug thesofproject#472 by giving the DSP more time to wake up! More recently it was found after merging and reverting an earlier version of this (PR thesofproject#543 / commit f93a3c8) that this first sleep was (accidentally?) giving more time for processes to actually disappeared after being killed at the end of a test round and not pollute the next test iteration. Make that clearer by moving the first sleep to the end of the iteration, right after the kills and hardcode to one second. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
In https://sof-ci.01.org/softestpr/PR671/build685/devicetest/ I hardcoded the loop count to 50 and did not see any pollution of one iteration to the next like in #543 (comment) |
marc-hb
changed the title
Contributor
|
Verified this PR on several TGL platform, sleep 1 is enough for process to clean up completely. |
keqiaozhang
approved these changes
Apr 29, 2021
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the same -w parameter for two different sleeps in the same
iteration made no sense.
It was not clear what the purpose of this first sleep was, it has been in
multiple-pipeline-capture/playback.sh since the dawn of time (= commit
39cd964) For sure this first sleep was helping hide
"uninterruptible state" bug #472 by giving the DSP more time to wake up!
More recently it was found after merging and reverting an earlier
version of this (PR #543 / commit f93a3c8) that this first sleep
was (accidentally?) giving more time for processes to actually
disappeared after being killed at the end of a test round and not
pollute the next test iteration. Make that clearer by moving the first
sleep to the end of the iteration, right after the kills and hardcode to
one second.