-
Notifications
You must be signed in to change notification settings - Fork 59
multiple-pipeline: add delay before ps_checks #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sometimes last aplay or arecord process might delay to start. This causes the test case to fail due to number of PIDs mistmatch. This is not 100% reproducible but slower platform has more chance to fail. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
marc-hb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we unfortunately need this because of my tentative explanation in #672. If you agree with it then please summarize it in the comment here and maybe add a link to it.
|
@marc-hb left a detailed explanation about the problem. We will find better management of background processes... later. |
|
@keqiaozhang @fredoh9 @marc-hb As I observed from Keqiao's demo, aplay/arecord process from last iteration may not be fully killed at the current iteration, so are you sure it is due to |
|
Which demo? "Not fully killed" sounds like another issue. |
When Keqiao found the issue days before, he ran this case once, and I checked the log. Without the sleep here, for example, in iteration 0, four aplay/arecord processes are started and killed, PIDs = [0 1 2 3], In the second iteration, we start four aplay/arecord again, PIDs=[4 5 6 7], but in the first ps check of the second iteration, six aplay/arecord processes are detected, PIDs=[0 1 4 5 6 7], two are from iteration 0, in the second ps check of the second iteration, only four pipelines are detected(PIDs=[ 4 5 6 7]), and test case thinks it started 6 process, but only 4 were alive at the end, so it failed. That's why I said |
|
#676 is merged |
|
Thanks @aiChaoSONG , that really sounds like a different issue to me. Let's keep an eye on it and if it happens again let's please discuss it in a better place than this abandoned PR :-) |
|
@marc-hb @keqiaozhang @aiChaoSONG Yes that is different issue. If you have seen that problem, please open a new issue. I remember the same error in long time ago. I think that will be not so easy to reproduce the problem. |
Sometimes last aplay or arecord process might delay to start. This causes
the test case to fail due to number of PIDs mistmatch. This is not 100%
reproducible but slower platform has more chance to fail.
Signed-off-by: Fred Oh fred.oh@linux.intel.com
fixes: #672