check-sof-logger: fix bug that did not kill/clean sof-logger -t #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty tabs are confusing, especially so because there's nothing that says "stderr" in their name or anywhere. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Killing sudo does NOT kill the sof-logger child! Use timeout as root instead. We probably got away with it because of the various "pkill sof-logger" out there. Fixes 8732f67 ("check-sof-logger: rewrite most of it so it can actually find bugs ") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
The only (alsabat) failure in https://sof-ci.01.org/softestpr/PR711/build746/devicetest/?model=CML_SKU0955_HDA&testcase=check-alsabat-headset-playback is not a test modified by this PR |
fredoh9
approved these changes
Jun 19, 2021
Contributor
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
printing filename in empty file is good idea.
I like timeout...wait change also.
Collaborator
Author
|
Thanks for the prompt review. Pure bug fix blocking other stuff, expediting this sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits. Main fix:
Killing sudo does NOT kill the sof-logger child! Use timeout as root
instead.
We probably got away with it because of the various "pkill sof-logger"
out there.
Fixes 8732f67 ("check-sof-logger: rewrite most of it so it can
actually find bugs ")
Signed-off-by: Marc Herbert marc.herbert@intel.com