check-sof-logger: fix FAIL message to point at the correct file #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message with "${data_file}" was kept even when the code was
extended to check the etrace too.
Fixes commit 8732f67 ("check-sof-logger: rewrite most of it so it
can actually find bugs")
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR798/build916/devicetest/ has the usual rtcwake TIMEOUT + ADL was not available. Everything else is green. |
fredoh9
approved these changes
Nov 1, 2021
Contributor
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
thank you for a quick fix
Collaborator
Author
|
Thanks @fredoh9 for the quick review. This failure has been happening with the wrong error message, so I'm fast-tracking this fix. Example: https://sof-ci.01.org/sofpr/PR4724/build10447/devicetest/?model=BDW_WSB_RT286&testcase=check-sof-logger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message with "${data_file}" was kept even when the code was
extended to check the etrace too.
Fixes commit 8732f67 ("check-sof-logger: rewrite most of it so it
can actually find bugs")
Signed-off-by: Marc Herbert marc.herbert@intel.com