checkpoints: do not use SOF_TEST_INTERVAL in test _iterations_ #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of test code is to find problems, not hide them. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
The purpose of SOF_TEST_INTERVAL is to avoid log gaps between tests, _not_ between test iterations of the same test. Fixes issue where the (recent) check-kmod-load-unload.sh was catching _multiple_ firmware boots, including boots from previous test iterations, example: sof-test/test-case/check-mod-load-unload.sh -l 50 Polling 'sof_firmware_boot_complete --since=@1646100584' every 1s for 10s [ 2968.155103] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: firmware boot complete [ 2970.706560] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: firmware boot complete [ 2974.522111] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: firmware boot complete Completed 'sof_firmware_boot_complete --since=@1646100584' after 0s and 1 attempts This may fix other, similar tests too. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits, the main one:
The purpose of SOF_TEST_INTERVAL is to avoid log gaps between tests,
not between test iterations of the same test.
Fixes issue where the (recent) check-kmod-load-unload.sh was catching
multiple firmware boots, including boots from previous test
iterations, example:
This may fix other, similar tests too.
cc: