hijack.sh: don't downgrade real fails together with sof-logger failures #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 27ae328 ("Downgrade Zephyr DMA trace corruption 5352 to a SKIP") downgraded sof-logger failures to SKIPs. Unfortunately, it also downgraded real failures. Check the current exit_status to see if a real failure was already found and don't downgrade it. Fixes thesofproject#901 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
None of the 3 failures in https://sof-ci.01.org/softestpr/PR903/build21/devicetest/ is related to this PR. |
miRoox
approved these changes
May 10, 2022
keqiaozhang
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 27ae328 ("Downgrade Zephyr DMA trace corruption 5352 to a
SKIP") downgraded sof-logger failures to SKIPs. Unfortunately, it also
downgraded real failures. Check the current exit_status to see if a real
failure was already found and don't downgrade it.
Fixes #901
Signed-off-by: Marc Herbert marc.herbert@intel.com