-
Notifications
You must be signed in to change notification settings - Fork 59
check-suspend-resume: add new -u option to test without audio #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per rationale detailed in thesofproject#740. Also add new $TOPDIR constant. Absolutely zero functional change. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This should help identifying suspend/resume issues unrelated to audio Signed-off-by: Marc Herbert <marc.herbert@intel.com>
7ef3c8a to
87064e9
Compare
|
Unrelated EDIT: fixed by removing all snaps |
| do | ||
| sleep_once "$i" | ||
| done | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a checkpoint here before reloading audio drivers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be but it's not really necessary because one of the last thing sleep_once did is to check the kernel logs and die if that failed. So if the execution makes it to this point it means the kernel logs are free of errors so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree, it's more that if you get an error while loading audio drivers it might be a bit difficult to check if the test worked until the point where you start loading driver. You'd get a fail and no intermediate information, that's it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will see the difference because of the different die error message; one is dump_and_die "Caught error in kernel log" whereas the other one below is die "Found kernel error after reloading audio drivers"
Setting the $KERNEL_CHECKPOINT is completely quiet so it won't help in that respect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think of $KERNEL_CHECKPOINT as a way to avoid errors from previous tests but inside the same test looking for errors and dying is actually a "stronger" checkpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to trust you on that, I don't have any context here.
plbossart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
There is another, theoretical problem with
But still, @aiChaoSONG , @fredoh9 thoughts? |
This should help identifying suspend/resume issues unrelated to audio
2 commits must be reviewed separately