Fix hijack.sh sudo() to use an array, support whitespace and behave #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found by chance that /var/log/kernel.log can rotate which means this overly complicated script not only duplicates `journalctl -k` it also duplicates it in a buggy way. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Overriden commands should work exactly like real commands and support whitespace and special characters exactly like the real command. I usually disable the sudo() override locally when using `set -x` to reduce trace noise considerably. The previous difference between the sudo() override and the built-in sudo() cost me couple hours twice: - WIP thesofproject#897 (comment) - Merged commit 232d40a No more! Also fix the return value: 2 means SKIP. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
fix-sudo-override
branch
from
5ad8624 to
90aae7b
Compare
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR943/build110/devicetest/ is all green! |
This was referenced Jul 26, 2022
Closed
Collaborator
Author
|
thanks @keqiaozhang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriden commands should work exactly like real commands and support
whitespace and special characters exactly like the real command.
I usually disable the sudo() override locally when using
set -xto reduce trace noise considerably. The previous difference between the
sudo() override and the built-in sudo() cost me couple hours twice:
No more!
Also fix the return value: 2 means SKIP.
Signed-off-by: Marc Herbert marc.herbert@intel.com