Skip to content

Commit ee5efdf

Browse files
marc-hbkv2019i
authored andcommitted
src/arch/xtensa/CMakeLists.txt: drop bogus, non-portable -Wl,-EL
As already discussed in commit bcbcec7 ("cmake: drop binutils-specific '-Wl,-EL' option") and commit ee58fef ("smex/cmake: move -Wl,EL option to target_linker_options() for clang") and their corresponding reviews on GitHub, this binutils-specific, endianness option makes no difference and is causing clang compatibility issues. It's now getting in the way of #9351 "Add the new platform ACP_7_0". I ran `./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a` with and without it and there was absolutely zero binary difference. I was added in 2019 by giant commit e0ba98d ("cmake: add CMakeLists for firmware build") without any rationale of why it would be needed. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 3f873a6 commit ee5efdf

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/arch/xtensa/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ target_compile_options(sof_options INTERFACE
123123
$<$<COMPILE_LANGUAGE:C>:
124124
-${optimization_flag} -g
125125
-Wall -Werror
126-
-Wl,-EL
127126
-Wmissing-prototypes
128127
-Wpointer-arith
129128
${XTENSA_C_FLAGS}

0 commit comments

Comments
 (0)