Commit ee5efdf
src/arch/xtensa/CMakeLists.txt: drop bogus, non-portable -Wl,-EL
As already discussed in commit bcbcec7 ("cmake: drop
binutils-specific '-Wl,-EL' option") and commit ee58fef
("smex/cmake: move -Wl,EL option to target_linker_options() for clang")
and their corresponding reviews on GitHub, this binutils-specific,
endianness option makes no difference and is causing clang compatibility
issues. It's now getting in the way of #9351 "Add the new platform
ACP_7_0".
I ran `./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a` with
and without it and there was absolutely zero binary difference.
I was added in 2019 by giant commit e0ba98d ("cmake: add CMakeLists
for firmware build") without any rationale of why it would be needed.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>1 parent 3f873a6 commit ee5efdf
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
| |||
0 commit comments