Skip to content

[BUG] Smart Amp needs to handle pause/stop like a mixer/mux #3837

@plbossart

Description

@plbossart

Describe the bug

The Smart Amp by construction takes as sources the playback stream and the capture feedback stream.
When pausing or stopping the smart amp, we need to make sure the state of the feedback stream is taken into account. If the feedback is active or paused, the component needs to remain active.

This should be generalized to ALL components that take multiple sources into account.

This is a potential reason for issues with the multiple-pause-resume tests that fail on a recurring basis on TGL SoundWire chromebook.

To Reproduce
run multiple-pause-resume tests.

Reproduction Rate
100%

Expected behavior
the smart amp deals with pause gracefully no matter whether the playback or feedback streams are paused/stopped.

Impact
This does not impact ChromeOS (Pause is not used) but wrecks our CI tests, and in general keeps SOF from correctly dealing with components with multiple sources.

Metadata

Metadata

Assignees

Labels

PipelineSDWSoundWireTGLApplies to Tiger LakebugSomething isn't working as expected

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions