[BUG] no sound coming from speakers when playing 16-bit clips on DeepBuffer PCM dev

[yongzhi1]

Describe the bug
16-bit playback from DeepBufer dev generates no audible sound.

To Reproduce
Run the following cmd and check the sound from speakers:

aplay -Dhw:0,11 -c2 -r48000 -fS16_LE /home/sample.wav -vv

Reproduction Rate
100%

Expected behavior
Expect to hear sound as if we are playing from sofrt5682 [sof-rt5682], device 1: Speakers

Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)

Environment

1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
   • Kernel: https://chromium.googlesource.com/a/chromiumos/third_party/kernel/+/refs/heads/chromeos-5.15 + Enable ipc4 d0i3 setting linux#3928
   • SOF: https://github.com/thesofproject/sof/tree/mtl-001-drop-stable
2. Name of the topology file
   • Topology: https://github.com/yongzhi1/sof/tree/deepbuffer
3. Name of the platform(s) on which the bug is observed.
   • Platform: MTL-RVP

Screenshots or console output

[RanderWang]

@yongzhi1 it is a sdw platform ? do you have kernel log ? And is it caused by 16bits ?

[yongzhi1]

Hi @RanderWang , it's I2S rt5682+max, 32-bit playback works fine although I only tested once, here is the log for 16-bit playback:
dmesg-deepplay-16b.txt

[RanderWang]

It works on SDW and HDA platform. I only tested with nocodec tplg since we don't have a platform with I2S codec. It is not caused by deep buffer setting, instead about SSP format selection in driver. I will debug it. Currently SSP uses 24bit valid sample bits /32bit container size, but it should use 32/32

static int sof_ipc4_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd,
				       struct snd_pcm_hw_params *params)
{
        ....

	switch (ipc4_copier->dai_type) {
	case SOF_DAI_INTEL_SSP:
		ipc4_ssp_dai_config_pcm_params_match(sdev, (char *)rtd->dai_link->name, params);
		break;
	default:
		break;
	}

	return 0;
}

[RanderWang]

@yongzhi1 The mixout-gain-dai-copier-playback.conf is for HDA by default and you override copier at https://github.com/yongzhi1/sof/blob/deepbuffer/tools/topology/topology2/cavs/cavs-rt5682.conf#L165, can you also override the format ? use only 32/32 ?
[update] this way can't work since driver can't use it.

[yongzhi1]

Hi, @RanderWang, thanks for the analysis, made the following changes, but did not see improvement.

--- a/tools/topology/topology2/cavs/cavs-rt5682.conf
+++ b/tools/topology/topology2/cavs/cavs-rt5682.conf
@@ -163,12 +163,29 @@ Object.Pipeline {
                        copier_type "SSP"
                        stream_name "SSP0-Codec"
                        node_type $I2S_LINK_OUTPUT_CLASS
+
+                       num_audio_formats 1
+                       # 16-bit input format 48KHz 2ch. Output sample format is always 32-bit for playback
+                       Object.Base.audio_format.1 {
+                               out_bit_depth           32
+                               out_valid_bit_depth     32
+                               dma_buffer_size "$[$ibs * $DEEPBUFFER_FW_DMA_MS]"
+                       }

Also the volume level from Spk sound fine w/o above changes:

card 0: sofrt5682 [sof-rt5682], device 1: Speakers () [] <= vol OK
card 0: sofrt5682 [sof-rt5682], device 11: Deepbuffer Amps () [] <= silent playing observed

Let me try to override the deepbuffer pipleline.

[RanderWang]

@yongzhi1 can you share the kernel msg ? we don't have a platform with I2S codec so we can't try. And how about my PR 4016 ? Thanks!

[yongzhi1]

Second try, still did not make any difference.dmesg-deep-override.txt

        }
+
+       deepbuffer-playback.15 {
+               index   1
+
+               Object.Widget.copier."1" {
+                       node_type $I2S_LINK_OUTPUT_CLASS
+                       num_audio_formats 2
+
+                       Object.Base.audio_format.1 {
+                               out_bit_depth           32
+                               out_valid_bit_depth     32
+                               dma_buffer_size "$[$obs * $DEEPBUFFER_FW_DMA_MS]"
+                       }
+                       Object.Base.audio_format.2 {
+                               in_bit_depth            32
+                               in_valid_bit_depth      32
+                               out_bit_depth           32
+                               out_valid_bit_depth     32
+                               # 100ms buffer
+                               dma_buffer_size "$[$ibs * $DEEPBUFFER_FW_DMA_MS]"
+                       }
+               }
+       }
 }
 
 Object.PCM {

Log for PR4016, dmesg-pr4016.txt, no sound still.