ADL: Load tplg file and return lots of errors from SOF driver

[davidrau-renesas-opensource]

1. Environment:

• Intel 12th ADL platform + CS42L42-SDW codec
• Linux v6.5

2. Situation:
I tried the available tplg files (for ADL) to bring-up the onboard codec and then got lots of error message from SOF driver.
(e.g. sof-adl-nocodec.tplg, )

[ 15.592511] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040380
[ 15.592762] sof-audio-pci-intel-tgl 0000:00:1f.3: SoundWire enabled on CannonLake+ platform, using SOF driver
[ 15.592782] sof-audio-pci-intel-tgl 0000:00:1f.3: enabling device (0000 -> 0002)
[ 15.593274] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040380
[ 15.593476] sof-audio-pci-intel-tgl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[ 15.600749] sof-audio-pci-intel-tgl 0000:00:1f.3: use msi interrupt mode
[ 15.771673] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 4
[ 15.771674] sof-audio-pci-intel-tgl 0000:00:1f.3: hda codecs found, mask 4
[ 15.975370] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:0:0-b678a
[ 15.975374] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:20:0 Kernel ABI 3:23:0
[ 15.975382] sof-audio-pci-intel-tgl 0000:00:1f.3: unknown sof_ext_man header type 3 size 0x30
[ 16.085714] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:0:0-b678a
[ 16.085731] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:20:0 Kernel ABI 3:23:0
[ 16.205352] sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:20:0 Kernel ABI 3:23:0
[ 16.205416] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI ALH2.OUT stream SDW0-Playback
[ 16.207010] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : ALH2.OUT stream SDW0-Playback
[ 16.210194] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI ALH3.IN stream SDW0-Capture
[ 16.211317] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 28 name : ALH3.IN stream SDW0-Capture
[ 16.213025] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI HDA3.OUT stream iDisp4
[ 16.213423] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : HDA3.OUT stream iDisp4
[ 16.214678] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI SSP2.OUT stream SSP2-BT
[ 16.215092] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : SSP2.OUT stream SSP2-BT
[ 16.216325] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI SSP2.IN stream SSP2-BT
[ 16.216741] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 28 name : SSP2.IN stream SSP2-BT
[ 16.218060] sof-audio-pci-intel-tgl 0000:00:1f.3: error: sink ALH2.OUT not found
[ 16.219458] sof-audio-pci-intel-tgl 0000:00:1f.3: error: source ALH3.IN not found
[ 16.220794] sof-audio-pci-intel-tgl 0000:00:1f.3: error: sink HDA3.OUT not found
[ 16.220796] sof-audio-pci-intel-tgl 0000:00:1f.3: error: sink SSP2.OUT not found
[ 16.220798] sof-audio-pci-intel-tgl 0000:00:1f.3: error: source SSP2.IN not found
[ 16.226628] sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx error for 0x30030000 (msg/reply size: 16/0): -22
[ 16.226631] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_route_setup: route BUF14.0 -> PCM14C failed
[ 16.226632] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_set_up_all_pipelines: route set up failed
[ 16.226633] sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg component load failed -22
[ 16.226638] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -22
[ 16.226640] sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22

Some questions as following.

• Would you please let me know how to solve this errors to make the codec become workable?
• Are there any available tplg file support this codec in ADL platform?
• May I refer to the existing tplg file (*.m4) to create a new one to access this codec correctly?

Thank you.

Best,
David

[lgirdwood]

@charleskeepax @rfvirgil @bardliao is there a topology file for CS42L42 ?

[lgirdwood]

@davidrau-renesas-opensource there may also be driver updates needed too, best to align with @charleskeepax and @rfvirgil here.

[davidrau-renesas-opensource]

Hi @lgirdwood ,
Thanks for the prompt response.

@davidrau-renesas-opensource there may also be driver updates needed too, best to align with @charleskeepax and @rfvirgil here.

Hi charleskeepax and Richard,
Nice to meet you.

My current test environment bases on Linux_v6.5.
I took some time to bring-up the on-board codec CS42L42-SDW but still failed of parsing the tplg.

Any sugeestions to fix it on my own?

Thanks.

Best,
David

[bardliao]

@charleskeepax @rfvirgil @bardliao is there a topology file for CS42L42 ?

We have sof-mtl-sdw-cs42l42-l0-max98363-l2.tplg for MTL, but not for ADL.
https://github.com/thesofproject/sof/blob/main/tools/topology/topology2/sof-ace-tplg/tplg-targets.cmake#L71

@davidrau-renesas-opensource Please rename sof-dyndbg.conf.txt to sof-dyndbg.conf and put it in the /etc/modprobe.d/ folder and get the dmesg again.

BTW, do you have the audio HW configuration in detail? For example, cs42l42 in sdw link 0, max98363 in sdw link 2.

[davidrau-renesas-opensource]

@bardliao
Thanks for the kind response.
Please refer to the following info about my current modifications to probe CS42L42-SDW in ADL.

According to the info of "sdw_intel_ctx", the default ids is configured for RT711.
In order to pass the default ids checking mechanism in sof-hda driver, I created my own fake id table in ADL ACPI code.
static const struct snd_soc_acpi_adr_device cs42l42_adr[] = {
{
.adr = 0x000120025D071101ull,
.num_endpoints = 1,
.endpoints = &single_endpoint,
.name_prefix = "cs42l42-sdw"
}
};

The attachment is my complete bootup log message after applying sof-dyndbg.conf.
cs42l42.log

About HW configuration, CS42L42 is connected to 2 kinds of SNDW link accoring to the HW option.

• SNDW_DAT0 and SNDW_CLK0
• SNDW_DAT1 and SNDW_CLK1

Please provide me any suggestions about this information.
Thanks a lot. :)

[bardliao]

@davidrau-renesas-opensource It will be easier to connect the cs42l42 on sdw link 0.
Please make sure sdw link 0 and only sdw link 0 is enabled in the BIOS.
Please follow the instruction in https://github.com/thesofproject/acpi-scripts to add cs42l42 sdw adr.

sudo ./install_hooks
sudo acpi-add <directory>/*.asl

Here is an example for adl cs42l42 adl-cs42l42.asl.txt
Here is the kernel patch
0001-ASoC-Intel-soc-acpi-intel-adl-match-add-cs42l42-supp.patch

And you can rename sof-adl-rt711-4ch.tplg and sof-adl-rt711.tplg to sof-adl-cs42l42-4ch.tplg and sof-adl-cs42l42.tplg

Please share the dmesg with those changes.

[davidrau-renesas-opensource]

@bardliao
Thanks for the prompt response.
According to on my "HD Audio configuration" of BIOS setting, there are "SNDW #1" and "SNDW #2" options.
So I enabled "SNDW #1" only and the log message shows the link mask is "0x2" as below.
[ 16.206603] hda_sdw_machine_select() - link_mask = 0x2
=> Does "link_mask = 0x2" mean the link#1 is connected in my dev-kit?

If my understanding is correct, the related setting should be confiuged to "link#1". Is't it? :)
E.g. (adl-cs42l42.asl)
Scope (_SB.PC00.HDAS.SNDW) {
Device (CS1) // CS42L42 on link1
{
Name (_ADR, 0x00000001fa424200) // _ADR: Address
}
}

And the following modificatins of ADL ACPI code are also needed?
.link_mask = 0x2
.mask = BIT(1)

[davidrau-renesas-opensource]

@bardliao
I tried to run acpi-add command with adl-cs42l42.asl (with link#1) and integrate you patch into my test environment.
There are 2 log messages to let you know my current test cases.

1. acpi-add command + integrate kernel patch:
   cs42l42-add-acpi-1.txt
   => The default ids for RT711 is requested and then load the default hda_dsp_generic tplg.

2. acpi-add command + integrate kernel patch + bypass default ids checking in hda.c:
   cs42l42-add-acpi-2.txt
   => sof-adl-sdw-cs42l42-4ch.tplg is loaded but slave Entry not found.

And ideas about my test result?
Thanks.

[bardliao]

@bardliao Thanks for the prompt response. According to on my "HD Audio configuration" of BIOS setting, there are "SNDW #1" and "SNDW #2" options. So I enabled "SNDW #1" only and the log message shows the link mask is "0x2" as below. [ 16.206603] hda_sdw_machine_select() - link_mask = 0x2 => Does "link_mask = 0x2" mean the link#1 is connected in my dev-kit?

It means your cs42l43 should be connected to SNDW_DAT1 and SNDW_CLK1. And it looks like there is no SNDW #0 option in your BIOS. And my patch assumes the cs42l42 is connected to SNDW_DAT0 and SNDW_CLK0

Let's connect the cs42l42 on SNDW_DAT0 and SNDW_CLK0 and use kernel option to overwrite the mask to 0x1.
options snd_intel_sdw_acpi sdw_link_mask=0x1

If my understanding is correct, the related setting should be confiuged to "link#1". Is't it? :) E.g. (adl-cs42l42.asl) Scope (_SB.PC00.HDAS.SNDW) { Device (CS1) // CS42L42 on link1 { Name (_ADR, 0x00000001fa424200) // _ADR: Address } }

And the following modificatins of ADL ACPI code are also needed? .link_mask = 0x2 .mask = BIT(1)

Connecting your cs42l42 to link 0 can reuse the existing topology. Yes, we can use link 1, and all above change is correct. .You need to change adr to 0x00010001fa424200ull, in cs42l42_0_adr[], too. And you need to connect your cs42l42 to SNDW_CLK1 and SNDW_DAT1. However, in this case, you will need to change the topology.

diff --git a/tools/topology/topology1/sof-tgl-rt711-rt1308.m4 b/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
index 73f3bc7b67ae..ed92fe67ad28 100644
--- a/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
+++ b/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
@@ -166,14 +166,14 @@ dnl     deadline, priority, core, time_domain)
 # playback DAI is ALH(SDW0 PIN2) using 2 periods
 # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0
 DAI_ADD(sof/pipe-mixer-volume-dai-playback.m4,
-       1, ALH, 2, SDW0-Playback,
+       1, ALH, 258, SDW0-Playback,
        NOT_USED_IGNORED, 2, s24le,
        1000, 0, 0, SCHEDULE_TIME_DOMAIN_TIMER, 2, 48000)

 # capture DAI is ALH(SDW0 PIN2) using 2 periods
 # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0
 DAI_ADD(sof/pipe-dai-capture.m4,
-       2, ALH, 3, SDW0-Capture,
+       2, ALH, 259, SDW0-Capture,
        PIPELINE_SINK_2, 2, s24le,
        1000, 0, 0, SCHEDULE_TIME_DOMAIN_TIMER)

Rebuild the topology and use the sof-adl-rt711-4ch.tplg

[davidrau-renesas-opensource]

@bardliao

You need to change adr to 0x00010001fa424200ull, in cs42l42_0_adr[]

I also modified the _ADR in "adl-cs42l42.asl" as below.
Device (CS1) // CS42L42 on link1
{
Name (_ADR, 0x00010001fa424200) // _ADR: Address
}

According to the boot message, the ACPI table is already applied to the sysytem successfully.
[ 0.020462] ACPI: SSDT ACPI table found in initrd [kernel/firmware/acpi/adl-cs42l42.aml][0x66]

And then the following messages tell us the previous modifications we did are correct. doesn't?
[ 15.091262] hda_sdw_machine_select() - link_mask = 0x2
[ 15.091263] mfg_id = 1fa, part_id = 4242, link_id = 1, version = 0
[ 15.091264] ids[0].link_id = 1, ids[0].id.part_id = 711, ids[0].id.mfg_id = 25d, ids[0].id.sdw_version = 2
[ 15.091265] ids[1].link_id = 1, ids[1].id.part_id = 4242, ids[1].id.mfg_id = 1fa, ids[1].id.sdw_version = 0
[ 15.091267] snd_sof_intel_hda_common:link_slaves_found: sof-audio-pci-intel-tgl 0000:00:1f.3: found 4242 at link 1

Next, the SOF driver loads the tplg file we created "sof-adl-sdw-cs42l42-4ch.tplg".
It seems "ALH258.out" is not workable in my current environment.
[ 15.711478] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI ALH258.OUT stream SDW0-Playback
[ 15.712989] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : ALH258.OUT stream SDW0-Playback
[ 15.714277] sof_sdw sof_sdw: ASoC: failed to load widget ALH258.OUT
[ 15.715698] sof_sdw sof_sdw: ASoC: topology: could not load header: -22

And ideas?

The complete log message is for your reference.
cs42l42-link1.txt

Thank. you.

[bardliao]

@davidrau-renesas-opensource Sorry, I missed something in the pervious topology patch. We need to change the BE name, too.
Please use the new patch.

diff --git a/tools/topology/topology1/sof-tgl-rt711-rt1308.m4 b/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
index 73f3bc7b67ae..fc192f981d8c 100644
--- a/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
+++ b/tools/topology/topology1/sof-tgl-rt711-rt1308.m4
@@ -166,14 +166,14 @@ dnl     deadline, priority, core, time_domain)
 # playback DAI is ALH(SDW0 PIN2) using 2 periods
 # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0
 DAI_ADD(sof/pipe-mixer-volume-dai-playback.m4,
-       1, ALH, 2, SDW0-Playback,
+       1, ALH, 258, SDW1-Playback,
        NOT_USED_IGNORED, 2, s24le,
        1000, 0, 0, SCHEDULE_TIME_DOMAIN_TIMER, 2, 48000)

 # capture DAI is ALH(SDW0 PIN2) using 2 periods
 # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0
 DAI_ADD(sof/pipe-dai-capture.m4,
-       2, ALH, 3, SDW0-Capture,
+       2, ALH, 259, SDW1-Capture,
        PIPELINE_SINK_2, 2, s24le,
        1000, 0, 0, SCHEDULE_TIME_DOMAIN_TIMER)

@@ -276,12 +276,12 @@ PCM_PLAYBACK_ADD(HDMI 4, 8, PIPELINE_PCM_9)

 #ALH dai index = ((link_id << 8) | PDI id)
 #ALH SDW0 Pin2 (ID: 0)
-DAI_CONFIG(ALH, 2, 0, SDW0-Playback,
-       ALH_CONFIG(ALH_CONFIG_DATA(ALH, 2, 48000, 2)))
+DAI_CONFIG(ALH, 258, 0, SDW1-Playback,
+       ALH_CONFIG(ALH_CONFIG_DATA(ALH, 258, 48000, 2)))

 #ALH SDW0 Pin3 (ID: 1)
-DAI_CONFIG(ALH, 3, 1, SDW0-Capture,
-       ALH_CONFIG(ALH_CONFIG_DATA(ALH, 3, 48000, 2)))
+DAI_CONFIG(ALH, 259, 1, SDW1-Capture,
+       ALH_CONFIG(ALH_CONFIG_DATA(ALH, 259, 48000, 2)))

 ifdef(`EXT_AMP',
 `

[davidrau-renesas-opensource]

@bardliao
Thanks for the prompt response.

After applying the new patch of tplg file, it shows the different error message about "DAI HDA3.OUT stream iDisp4".
[ 16.516344] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI HDA3.OUT stream iDisp4
[ 16.517698] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : HDA3.OUT stream iDisp4
[ 16.519085] sof_sdw sof_sdw: ASoC: failed to load widget HDA3.OUT
[ 16.520064] sof_sdw sof_sdw: ASoC: topology: could not load header: -22

So I took a try to disable the related definitations of "iDisp4" and then the new error mesage is about "SSP2.OUT stream SSP2-BT"
[ 16.896588] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI SSP2.OUT stream SSP2-BT
[ 16.897910] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : SSP2.OUT stream SSP2-BT
[ 16.899346] sof_sdw sof_sdw: ASoC: failed to load widget SSP2.OUT
[ 16.900003] sof_sdw sof_sdw: ASoC: topology: could not load header: -22

Any ideas?
Thanks.

[bardliao]

@davidrau-renesas-opensource It looks like there is no iDisp4 in your device. Please remove the HDA 3 stuff from the topology.
sof-tgl-rt711-rt1308.diff.txt

[davidrau-renesas-opensource]

@bardliao
HDA 3 stuff is already removed in the tplg now.
The remaining error message shows "SSP2.OUT stream SSP2-BT" is not avaiable in my device.
[ 16.611837] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI SSP2.OUT stream SSP2-BT
[ 16.613204] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : SSP2.OUT stream SSP2-BT
[ 16.614456] sof_sdw sof_sdw: ASoC: failed to load widget SSP2.OUT
[ 16.615222] sof_sdw sof_sdw: ASoC: topology: could not load header: -22

Would you please let me know how to remove this stuff correctly?

Thanks.