[BUG] Lenovo Yoga Slim 7 15 - SOF topology file not found

[cgbowman]

Describe the bug
The SOF topology file is not detected (topology doesn't exist) on a LNL Lenovo Yoga Slim 7 15 laptop.

To Reproduce
Install Ubuntu 24.10 on the laptop, build & install 6.12.0-rc7+ kernel, then boot the laptop.
Errors will be present in dmesg logs.

Reproduction Rate
All the time

Expected behavior
The topology file should exist and be detected.

Impact
Showstopper
At best, results in no audio (dummy output). At worst, sometimes results in a failed boot.

Environment

1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
   • Kernel: 6.12.0-rc7+ (drm-tip)
   • SOF: sof-bin-2024.09.1 (release)
2. Name of the topology file
   • Topology: intel/sof-ipc4-tplg/sof-lnl-cs42l43-l0-4ch.tplg
3. Name of the platform(s) on which the bug is observed.
   • Platform: Lenovo Yoga Slim 7 15

Screenshots or console output

[    5.459112] sof-audio-pci-intel-lnl 0000:00:1f.3: hda codecs found, mask 4
[    5.459115] sof-audio-pci-intel-lnl 0000:00:1f.3: NHLT device BT(0) detected, ssp_mask 0x4
[    5.459116] sof-audio-pci-intel-lnl 0000:00:1f.3: BT link detected in NHLT tables: 0x4
[    5.459117] sof-audio-pci-intel-lnl 0000:00:1f.3: DMICs detected in NHLT tables: 4
[    5.460831] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-p not found, using dummy regulator
[    5.460864] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-d not found, using dummy regulator
[    5.460872] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-a not found, using dummy regulator
[    5.460880] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-io not found, using dummy regulator
[    5.460889] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-cp not found, using dummy regulator
[    5.462775] sof-audio-pci-intel-lnl 0000:00:1f.3: SOF firmware and/or topology file not found.
[    5.462778] sof-audio-pci-intel-lnl 0000:00:1f.3: Supported default profiles
[    5.462779] sof-audio-pci-intel-lnl 0000:00:1f.3: - ipc type 1 (Requested):
[    5.462780] sof-audio-pci-intel-lnl 0000:00:1f.3:  Firmware file: intel/sof-ipc4/lnl/sof-lnl.ri
[    5.462781] sof-audio-pci-intel-lnl 0000:00:1f.3:  Topology file: intel/sof-ipc4-tplg/sof-lnl-cs42l43-l0-4ch.tplg
[    5.462782] sof-audio-pci-intel-lnl 0000:00:1f.3: Check if you have 'sof-firmware' package installed.
[    5.462782] sof-audio-pci-intel-lnl 0000:00:1f.3: Optionally it can be manually downloaded from:
[    5.462783] sof-audio-pci-intel-lnl 0000:00:1f.3:    https://github.com/thesofproject/sof-bin/

lenovo_yoga_dmesg.txt

[bardliao]

@charleskeepax @simontrimmer FYI

[simontrimmer]

Yes that's the one - there is a DMI match string change and the topology change we were talking about:

+++ b/tools/topology/topology2/production/tplg-targets-ace2.cmake
@@ -27,6 +27,13 @@ NUM_SDW_AMP_LINKS=2,SDW_DMIC_STREAM=SDW0-Capture"
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack"

+"cavs-sdw;sof-lnl-cs42l43-l0-4ch;PLATFORM=lnl,NUM_SDW_AMP_LINKS=1,NUM_DMICS=4,
+PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,DMIC0_ID=5,DMIC1_ID=6,
+PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-lnl-cs42l43-l0-4ch.bin,
+SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,
+SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,
+HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9"
+
"cavs-sdw;sof-lnl-cs42l43-l0-cs35l56-l3;PLATFORM=lnl,NUM_SDW_AMP_LINKS=1,SDW_DMIC=1,
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack"

We were hanging on "a few more" Lenovo DMI strings

[simontrimmer]

Having a crack at a PR with that topology change in, not my usual jam...

#9666

[bardliao]

@cgbowman The thesofproject/linux#5248 and #9666 PRs are merged. Can you check if they work for your device?

[cgbowman]

Was tinkering with the docker container setup, but seems I'm having issues getting the non-default build targets to show up. I'll keep tinkering until I get it to build correctly. Once I've been able to test, I'll post again. Thanks for the help here!

[cgbowman]

I was able to build the topology file with the docker image given by the SOF documentation, but after copying the topology over to the correct location, other errors are still present. I didn't rebuild the firmware binaries, as other targets weren't accepted by the docker image suggested by the instructions (even the 'cnl' target doesn't seem to be recognized as a valid target). It's possible that not rebuilding the rest of the lnl target may produce these errors, but I'm not familiar with this codebase, so I'm not sure.

[    7.483987] sof-audio-pci-intel-lnl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [xe])
[    7.491234] sof-audio-pci-intel-lnl 0000:00:1f.3: use msi interrupt mode
[    7.522036] sof-audio-pci-intel-lnl 0000:00:1f.3: hda codecs found, mask 4
[    7.522053] sof-audio-pci-intel-lnl 0000:00:1f.3: NHLT device BT(0) detected, ssp_mask 0x4
[    7.522057] sof-audio-pci-intel-lnl 0000:00:1f.3: BT link detected in NHLT tables: 0x4
[    7.522063] sof-audio-pci-intel-lnl 0000:00:1f.3: DMICs detected in NHLT tables: 4
[    7.529163] sof-audio-pci-intel-lnl 0000:00:1f.3: Firmware paths/files for ipc type 1:
[    7.529176] sof-audio-pci-intel-lnl 0000:00:1f.3:  Firmware file:     intel/sof-ipc4/lnl/sof-lnl.ri
[    7.529179] sof-audio-pci-intel-lnl 0000:00:1f.3:  Firmware lib path: intel/sof-ipc4-lib/lnl
[    7.529181] sof-audio-pci-intel-lnl 0000:00:1f.3:  Topology file:     intel/sof-ipc4-tplg/sof-lnl-cs42l43-l0-4ch.tplg
[    7.530298] sof-audio-pci-intel-lnl 0000:00:1f.3: Loaded firmware library: ADSPFW, version: 2.11.1.1
[    7.537583] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-p not found, using dummy regulator
[    7.537623] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-d not found, using dummy regulator
[    7.537641] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-a not found, using dummy regulator
[    7.537651] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-io not found, using dummy regulator
[    7.537658] cs42l43 sdw:0:0:01fa:4243:01: supply vdd-cp not found, using dummy regulator
[    7.540914] cs42l43 sdw:0:0:01fa:4243:01: devid: 0x042a43, rev: 0xa1, otp: 0x03
[    7.559314] fbcon: xedrmfb (fb0) is primary device
[    7.559321] fbcon: Deferring console take-over
[    7.559326] xe 0000:00:02.0: [drm] fb0: xedrmfb frame buffer device
[    7.563078] cs42l43 sdw:0:0:01fa:4243:01: Slave 6 state check1: UNATTACHED, status was 1
[    7.566856] xe 0000:00:02.0: [drm] GT1: found GSC cv104.1.0
[    7.572320] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    7.572324] Bluetooth: BNEP filters: protocol multicast
[    7.572328] Bluetooth: BNEP socket layer initialized
[    7.587982] Adding alias for supply vdd-amp,(null) -> vdd-amp,sdw:0:0:01fa:4243:01
[    7.676905] sof-audio-pci-intel-lnl 0000:00:1f.3: Booted firmware version: 2.11.1.1
[    7.692936] cs35l56 spi-cs35l56-left: supply VDD_P not found, using dummy regulator
[    7.692989] cs35l56 spi-cs35l56-left: supply VDD_IO not found, using dummy regulator
[    7.692999] cs35l56 spi-cs35l56-left: supply VDD_A not found, using dummy regulator
[    7.704826] cs42l43-codec cs42l43-codec: supply vdd-amp not found, using dummy regulator
[    7.706871] loop15: detected capacity change from 0 to 8
[    7.708502] sof-audio-pci-intel-lnl 0000:00:1f.3: Topology: ABI 3:29:1 Kernel ABI 3:23:1
[    7.708636] sof-audio-pci-intel-lnl 0000:00:1f.3: error: can't connect DAI alh-copier.Playback-SmartAmp.0 stream Playback-SmartAmp
[    7.708642] sof-audio-pci-intel-lnl 0000:00:1f.3: failed to add widget type 27 name : alh-copier.Playback-SmartAmp.0 stream Playback-SmartAmp
[    7.708650] sof_sdw sof_sdw: ASoC: failed to load widget alh-copier.Playback-SmartAmp.0
[    7.708652] sof_sdw sof_sdw: ASoC: topology: could not load header: -22
[    7.708661] sof-audio-pci-intel-lnl 0000:00:1f.3: error: tplg component load failed -22
[    7.708669] sof-audio-pci-intel-lnl 0000:00:1f.3: error: failed to load DSP topology -22
[    7.708671] sof-audio-pci-intel-lnl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
[    7.708691] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[    7.709398] sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[    7.709409] sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

Added full dmesg here:
lenovo_yoga_tplg_added.txt

[bardliao]

@cgbowman I guess your device is not listed in the sof_sdw_quirk_table[].
Can you share the output of sudo dmidecode | grep SKU?

[simontrimmer]

The DMI information matches the unit I was using (including the updated bios)

[simontrimmer]

Tangent - I wasn't getting "[ 8.008471] i2c_designware i2c_designware.2: i2c_dw_handle_tx_abort: lost arbitration"

[cgbowman]

@cgbowman I guess your device is not listed in the sof_sdw_quirk_table[]. Can you share the output of sudo dmidecode | grep SKU?

$ sudo dmidecode | grep SKU
        SKU Number: LENOVO_MT_83HM_BU_idea_FM_Yoga Slim 7 15ILL9
        SKU Number: SKU Number
                Consumer SKU

[bardliao]

@cgbowman Did you upgrade your kernel with thesofproject/linux#5248?

[cgbowman]

@cgbowman Did you upgrade your kernel with thesofproject/linux#5248?

Yes, I cherry-picked the necessary patches onto a drm-tip base, but can retry with just the branch by itself tomorrow morning if you'd like confirmation.

[bardliao]

@cgbowman Can you put sof-dyndbg.conf to the /etc/modprobe.d/ folder and share the full dmesg log? Note that the file should be rename to sof-dyndbg.conf. I.e. remove the .txt filename extension.