Skip to content

Conversation

@softwarecki
Copy link
Collaborator

Add support for ace 1.5 manifest to resign_image function. Subtract the number of skipped bytes from the file size to avoid going
beyond of memory buffer. Copy data preceding the cse header to the output file to preserve extended manifest.

Add support for ace 1.5 manifest to resign_image function.

Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Subtract the number of skipped bytes from the file size to avoid going
beyond of memory buffer.

Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Copy data preceding the cse header to the output file.

Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the new ACE 1.5 manifest format in resign_image.

  • Adjusts image_end to subtract skipped bytes from total size
  • Extends manifest version checks and invokes ri_manifest_sign_ace_v1_5
  • Copies the extended manifest region before the CSE header into the output file
Comments suppressed due to low confidence (3)

tools/rimage/src/manifest.c:1733

  • [nitpick] The variable 'i' is ambiguous; consider renaming it to something like 'header_offset' or 'skip_bytes' to clarify its purpose.
image->image_end = size - i;

tools/rimage/src/manifest.c:1783

  • The return value of 'man_write_fw_mod' is ignored; capture and check its result so you can abort on write failures instead of proceeding silently.
man_write_fw_mod(image);

tools/rimage/src/manifest.c:1758

  • You've added handling for ACE v1.5, but there aren’t any tests covering this new branch; please add unit tests for the ACE manifest path.
else if (image->adsp->man_ace_v1_5)

@softwarecki softwarecki changed the title rimage: Add support for resiging ace manifest rimage: Add support for resigning ace manifest May 27, 2025
@kv2019i kv2019i merged commit 9eed235 into thesofproject:main May 27, 2025
45 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants