Skip to content

module_adapter: Don't propagate ENOSPC and ENODATA error codes #10033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
May 29, 2025
Merged

module_adapter: Don't propagate ENOSPC and ENODATA error codes #10033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/audio/module_adapter/module/generic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ int module_process_sink_src(struct processing_module *mod,
/* reset state to idle */
md->state = MODULE_IDLE;
#endif
return ret;
return 0;
}

int module_reset(struct processing_module *mod)
Expand Down
9 changes: 6 additions & 3 deletions src/audio/module_adapter/module_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,9 +990,12 @@ static int module_adapter_sink_source_copy(struct comp_dev *dev)
ret = module_process_sink_src(mod, mod->sources, mod->num_of_sources,
mod->sinks, mod->num_of_sinks);

if (ret != -ENOSPC && ret != -ENODATA && ret) {
comp_err(dev, "module_adapter_sink_source_copy() process failed with error: %x",
ret);
if (ret) {
if (ret != -ENOSPC && ret != -ENODATA)
Copy link
Collaborator

@lyakh lyakh May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@softwarecki now I'm confused even more... module_process_sink_src() now cannot return -ENOSPC or -ENODATA, why are we still checking for them? If I'm right - can we improve this in a follow-up?

comp_err(dev, "module_adapter_sink_source_copy() process failed with error: %d",
ret);
else
ret = 0;
}

/* count number of processed data. To be removed in pipeline 2.0 */
Expand Down
Loading