Skip to content

llext: fix undefined symbols #10055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Jun 13, 2025
Merged

llext: fix undefined symbols #10055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ipc/ipc4/notification.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
#include <stdbool.h>
#include <ipc4/notification.h>

#include <rtos/symbol.h>

static void resource_notif_header_init(struct ipc_msg *msg)
{
struct ipc4_resource_event_data_notification *notif_data = msg->tx_data;
Expand Down Expand Up @@ -77,6 +79,7 @@ void mixer_underrun_notif_msg_init(struct ipc_msg *msg, uint32_t resource_id, ui
notif_data->event_data.mixer_underrun.data_mixed = data_mixed;
notif_data->event_data.mixer_underrun.expected_data_mixed = expected_data_mixed;
}
EXPORT_SYMBOL(mixer_underrun_notif_msg_init);
Copy link
Contributor

@jsarha jsarha Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the other notif_msg_init() functions called from the llext modules?

Copy link
Collaborator Author

@lyakh lyakh Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the other notif_msg_init() functions called from the llext modules?

@jsarha no, if they were, we'd get unresolved symbols for them too


void process_data_error_notif_msg_init(struct ipc_msg *msg, uint32_t resource_id,
uint32_t error_code)
Expand Down
3 changes: 3 additions & 0 deletions src/ipc/notification_pool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
#include <sof/list.h>
#include <sof/ipc/notification_pool.h>

#include <rtos/symbol.h>

#define NOTIFICATION_POOL_MAX_PAYLOAD_SIZE 40 /* IPC4 Resource Event needs 10dw */
#define NOTIFICATION_POOL_MAX_DEPTH 8 /* Maximum number of notifications
* in the pool
Expand Down Expand Up @@ -98,3 +100,4 @@ struct ipc_msg *ipc_notification_pool_get(size_t size)
item->msg.tx_size = size;
return &item->msg;
}
EXPORT_SYMBOL(ipc_notification_pool_get);
Loading