Skip to content

iadk: Fix GetConfiguration API function #10102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jul 22, 2025
Merged

iadk: Fix GetConfiguration API function #10102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/audio/module_adapter/iadk/iadk_module_adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ IadkModuleAdapter::IadkModuleAdapter_SetConfiguration(uint32_t config_id,
AdspErrorCode
IadkModuleAdapter::IadkModuleAdapter_GetConfiguration(uint32_t config_id,
enum module_cfg_fragment_position pos,
uint32_t data_offset_size,
uint32_t &data_offset_size,
uint8_t *fragment_buffer,
size_t fragment_size)
size_t &fragment_size)
{
intel_adsp::ConfigurationFragmentPosition fragment_position =
(intel_adsp::ConfigurationFragmentPosition::Enum) pos;
Expand Down Expand Up @@ -219,14 +219,14 @@ int iadk_wrapper_set_configuration(void *md, uint32_t config_id,

int iadk_wrapper_get_configuration(void *md, uint32_t config_id,
enum module_cfg_fragment_position pos,
uint32_t data_offset_size,
uint8_t *fragment, size_t fragment_size)
uint32_t *data_offset_size,
uint8_t *fragment, size_t *fragment_size)
{
struct IadkModuleAdapter *mod_adp = (struct IadkModuleAdapter *) md;
return mod_adp->IadkModuleAdapter_GetConfiguration(config_id, pos,
data_offset_size,
*data_offset_size,
fragment,
fragment_size);
*fragment_size);
}

int iadk_wrapper_process(void *md,
Expand Down
4 changes: 2 additions & 2 deletions src/audio/module_adapter/module/modules.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ static int modules_get_configuration(struct processing_module *mod, uint32_t con
size_t fragment_size)
{
return iadk_wrapper_get_configuration(module_get_private_data(mod), config_id,
MODULE_CFG_FRAGMENT_SINGLE, *data_offset_size,
fragment, fragment_size);
MODULE_CFG_FRAGMENT_SINGLE, data_offset_size,
fragment, &fragment_size);
}

/**
Expand Down
20 changes: 16 additions & 4 deletions src/include/sof/audio/module_adapter/iadk/iadk_module_adapter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ namespace dsp_fw
AdspErrorCode
IadkModuleAdapter_GetConfiguration(uint32_t config_id,
enum module_cfg_fragment_position fragment_position,
uint32_t data_offset_size,
uint32_t &data_offset_size,
uint8_t *fragment_buffer,
size_t fragment_size);
size_t &fragment_size);
/**
* Module specific reset procedure, called as part of codec_adapter component
* reset in .reset(). This should reset all parameters to their initial stage
Expand Down Expand Up @@ -144,10 +144,22 @@ int iadk_wrapper_set_configuration(void *md, uint32_t config_id,
const uint8_t *fragment, size_t fragment_size,
uint8_t *response, size_t response_size);

/*
* \brief Retrieve module configuration
* \param[in] md - struct IadkModuleAdapter pointer
* \param[in] config_id - Configuration ID
* \param[in] pos - position of the fragment in the large message
* \param[in] data_offset_size: size of the whole configuration if it is the first fragment or the
* only fragment. Otherwise, it is the offset of the fragment in the whole configuration.
* \param[in] fragment: configuration fragment buffer
Copy link
Contributor

@tmleman tmleman Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here https://github.com/thesofproject/sof/blob/main/src/include/sof/audio/module_adapter/iadk/processing_module_interface.h#L338-L367 fragment is described as output.

Copy link
Member

@lgirdwood lgirdwood Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks like we are good to go once the API buffer is aligned,

* \param[in,out] fragment_size: size of @fragment
*
* \return: 0 upon success or error upon failure
*/
int iadk_wrapper_get_configuration(void *md, uint32_t config_id,
enum module_cfg_fragment_position pos,
uint32_t data_offset_size,
uint8_t *fragment, size_t fragment_size);
uint32_t *data_offset_size,
uint8_t *fragment, size_t *fragment_size);

int iadk_wrapper_process(void *md,
struct sof_source **sources, int num_of_sources,
Expand Down
Loading