test: ztest: Add math basic trigonometry unit tests converted from CMock #10233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR converts 9 existing math trigonometry unit tests from CMock/Unity to Zephyr's Ztest framework, maintaining the same test coverage and functionality while establishing the foundation for math/basic/trigonometry tests in the new SOF Ztest directory structure.
- Conversion of trigonometric function tests (sin, cos, asin, acos) for both 16-bit and 32-bit fixed-point implementations
- Addition of sine lookup table test for 16-bit fixed-point
- Preservation of original reference tables and tolerance values to maintain identical test accuracy
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/ztest/unit/math/basic/trigonometry/trig_test.c | Main test file with 9 converted trigonometry tests using Ztest framework |
| test/ztest/unit/math/basic/trigonometry/trig_tables.h | Reference data tables and tolerance constants for trigonometry tests |
| test/ztest/unit/math/basic/trigonometry/testcase.yaml | Test configuration file defining test metadata and platform requirements |
| test/ztest/unit/math/basic/trigonometry/prj.conf | Zephyr project configuration enabling Ztest framework |
| test/ztest/unit/math/basic/trigonometry/CMakeLists.txt | CMake build configuration linking SOF math libraries and test sources |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 tasks
tmleman
force-pushed
the
topic/upstream/pr/unit_test/ztest/math/trigonometry
branch
from
f216226 to
40b6a9d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tmleman
force-pushed
the
topic/upstream/pr/unit_test/ztest/math/trigonometry
branch
2 times, most recently
from
448fabb to
385485a
Compare
This patch converts 9 existing math trigonometry unit tests from CMock/Unity to Zephyr's Ztest framework, maintaining the same test coverage and functionality: - test_sin_32b_fixed: 32-bit fixed-point sine function - test_sin_16b_fixed: 16-bit fixed-point sine function - test_cos_32b_fixed: 32-bit fixed-point cosine function - test_cos_16b_fixed: 16-bit fixed-point cosine function - test_asin_32b_fixed: 32-bit fixed-point arcsine function - test_asin_16b_fixed: 16-bit fixed-point arcsine function - test_acos_32b_fixed: 32-bit fixed-point arccosine function - test_acos_16b_fixed: 16-bit fixed-point arccosine function - test_sin_lut_16b_fixed: 16-bit sine lookup table function Original tests converted from sof/test/cmocka/src/math/trig/ authored by: - Slawomir Blauciak <slawomir.blauciak@linux.intel.com> - Shriram Shastry <malladi.sastry@linux.intel.com> - Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> The converted tests validate the same trigonometric functions from src/math/trig.c and src/math/lut_trig.c as the original CMock tests, ensuring no regression in test coverage during the migration to Ztest framework. Reference tables and tolerance values are preserved to maintain identical test accuracy and validation criteria. This is part of the broader SOF unit test migration from CMock to Zephyr Ztest framework, establishing the foundation for math/basic/trigonometry tests in the new directory structure. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
kv2019i
approved these changes
Sep 12, 2025
softwarecki
approved these changes
Oct 3, 2025
Collaborator
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
Nice cleanup! Migrating these tests to Ztest keeps coverage intact and moves us closer to a unified testing framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch converts 9 existing math trigonometry unit tests from CMock/Unity to Zephyr's Ztest framework, maintaining the same test coverage and functionality:
Original tests converted from sof/test/cmocka/src/math/trig/ authored by:
The converted tests validate the same trigonometric functions from src/math/trig.c and src/math/lut_trig.c as the original CMock tests, ensuring no regression in test coverage during the migration to Ztest framework. Reference tables and tolerance values are preserved to maintain identical test accuracy and validation criteria.
This is part of the broader SOF unit test migration from CMock to Zephyr Ztest framework, establishing the foundation for math/basic/trigonometry tests in the new directory structure.