Skip to content

zephyr: lib/alloc: Relax virtual_heap_alloc() assert condition #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Oct 31, 2025
Merged

zephyr: lib/alloc: Relax virtual_heap_alloc() assert condition #10345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zephyr/lib/alloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ static void *virtual_heap_alloc(struct vmh_heap *heap, uint32_t flags, size_t by
if (!mem)
return NULL;

assert(IS_ALIGNED(mem, align));
assert(align == 0 || IS_ALIGNED(mem, align));
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition align == 0 may be misleading since zero is not a valid alignment value for memory operations. Consider checking if align is a power of 2 when non-zero, or document that zero specifically means 'no alignment requirement' to clarify the API contract.

Copilot uses AI. Check for mistakes.

if (flags & SOF_MEM_FLAG_COHERENT)
return sys_cache_uncached_ptr_get((__sparse_force void __sparse_cache *)mem);
Expand Down
Loading