coredump-reader: formatting fixes #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonislawski
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
requested changes
Apr 3, 2019
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Some of these commit messages are missing why you are making the change. Please add more detail in commit messages.
Two separators didnt work correctly Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
This is to notice user that columncount option will work only with verbose Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
… more Now it is possible to pipe output with 'more' Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
To separate them visually for better reading Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
abonislawski
force-pushed
the
coredump-reader-f
branch
from
d2433f8 to
fac6840
Compare
Member
Author
|
@lgirdwood updated, please check it |
lgirdwood
approved these changes
Apr 4, 2019
Member
Author
|
I forgot to mention but now it will also work on the windows :) |
mmaka1
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting fixes for this issue:
#1217