audio: cleanup in components #1440
Conversation
tlauda
requested review from
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
src/audio/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Would be better to not handle f.e. volume.c on 2 different levels for different builds. We should have some kind of function here that is called in subdirs maybe. I can refactor that part later. We can merge it like it is now cos it's step in the good direction and it's better to have smaller PRs anyway.
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
looks good, minor comment on memcpy changes below
tlauda
force-pushed
the
topic/audio-comp-cleanup
branch
from
490fedc to
11c6585
Compare
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Nice clean-up.
Side comment: The use of 'assert' is questionable in an audio firmware. we should have a discussion on this, other firmware groups explicitly forbid this. Either an error check is needed or it's not. Even in previous host-based programs asserts were considered as evil.
|
@tlauda Please fix ut |
This patch moves multifile components to separate directories. All component headers are also moved to include/sof/audio. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Fixes checkpatch errors in audio components. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Replaces memcpy calls with memcpy_s calls in audio processing components. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Removes preprocessor checks for MODULE_TEST. It was used by testbench, when the FW traces were very limited. It's no longer needed. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/audio-comp-cleanup
branch
from
11c6585 to
f2b5f58
Compare
3 participants
Set of patches to cleanup audio components: