pipeline: change preload conditions #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes pipeline's preload conditions to take into consideration the situation, where we don't always want to do playback preload, because the sink part of pipeline is already running e.g. mixer topology. However the host component still needs to perform preload on its own, so for now we make the decision based on stream's direction. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
jajanusz
approved these changes
Jun 26, 2019
Contributor
Author
|
@lgirdwood @plbossart @ranj063 @kv2019i I don't like this fix, but as for now there is no other way to handle it nicely. It exposes our faulty way of constructing mixer topologies. Pipeline with mixer and dai components should be separate pipeline, which then could be separately handled. I think we already had some discussion about making mixer produce zeroes and extracting it to the other pipe. Right now the mixer and dai are the part of the first host stream, which makes it hard to manage. |
tlauda
added
bug
lgirdwood
approved these changes
Jun 29, 2019
Member
|
@tlauda agree, we need to spend some time on pipeline to make to simplify the logic and make the code more portable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes pipeline's preload conditions to take into
consideration the situation, where we don't always
want to do playback preload, because the sink part
of pipeline is already running e.g. mixer topology.
However the host component still needs to perform
preload on its own, so for now we make the decision
based on stream's direction.
Fixes #1526.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com