Skip to content

Conversation

@bkokoszx
Copy link
Collaborator

In alloc_cont_blocks() function after allocation we should
check whether new first_free block has been already used.
If it was used, we should find first not used block.

fixes #1714

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

In alloc_cont_blocks() function after allocation we should
check whether new first_free block has been already used.
If it was used, we should find first not used block.

fixes thesofproject#1714

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@lgirdwood
Copy link
Member

lgirdwood commented Sep 16, 2019

@fredoh9 @xiulipan CI false positive or issue ?

2019-09-16 08:58:23 UTC [REM_INFO]: read the topology pipleline from binary /lib/firmware/intel/sof-tplg/sof-hda-generic-4ch.tplg (4b06c398c1c2ed4a010480fdbbd59dde) ...
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=DMIC48kHz;ID=6;TYPE=capture;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=4;CH_MAX=4}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=DMIC16kHz;ID=7;TYPE=capture;FMT=s16le;RATE_MIN=16000;RATE_MAX=16000;CH_MIN=4;CH_MAX=4}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=HDA_Analog;ID=0;TYPE=both;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=2;CH_MAX=2}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=HDA_Digital;ID=1;TYPE=both;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=2;CH_MAX=2}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=HDMI1;ID=3;TYPE=playback;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=2;CH_MAX=2}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=HDMI2;ID=4;TYPE=playback;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=2;CH_MAX=2}
2019-09-16 08:58:23 UTC [REM_INFO]: Pipeline Found: {PCM=HDMI3;ID=5;TYPE=playback;FMT=s16le;RATE_MIN=48000;RATE_MAX=48000;CH_MIN=2;CH_MAX=2}
2019-09-16 08:58:23 UTC [REM_INFO]: Get playback list:
2019-09-16 08:58:23 UTC [REM_INFO]: Get capture list:
2019-09-16 08:58:23 UTC [REM_WARNING]: The /lib/firmware/intel/sof-tplg/sof-hda-generic-4ch.tplg doesn't match the loaded topology!
2019-09-16 08:58:28 UTC [REM_INFO]: === CASE FAILED ===

@wenqingfu
Copy link

@lgirdwood which test case did you get this "false positive" message? I cannot tell from your quote...

@wenqingfu
Copy link

@lgirdwood which test case did you get this "false positive" message? I cannot tell from your quote...

ok, I see. no, it's not a false negative case - the topology files says there are these PCMs but due to bios misalignment on this particular platform, SOF quit before creating these PCMs , thus it's a failed case. It's a known issue on the ICL RVP we use in CI so far.

@tlauda tlauda merged commit 03d6826 into thesofproject:master Sep 17, 2019
@xiulipan
Copy link
Contributor

@lrgirdwo @wenqingfu Yes, it is a known issue. The FW load is success but the machine driver load is failed due to hdmi codec probe failed.

@bkokoszx bkokoszx deleted the alloc-continious-block-fix branch March 10, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] allocating continious blocks can set wrong first free

5 participants