topology: sof-cht-max98090 move DAI definition above media pipeline #1846
Conversation
The DAI definition needs to come first otherwise the media pipeline with be parsed incorrectly resulting in a failure to load the topology Signed-off-by: Curtis Malainey <cujomalainey@google.com>
Reduce size of buffers so dsp doesn't run out of memory on topology load Signed-off-by: Curtis Malainey <cujomalainey@google.com>
|
@cujomalainey What is the exact problem? @xiulipan has recently fixed DAI_ADD macro, so maybe your change is no longer needed. |
|
@tlauda for some reason on ToT the topology will parse out differently and leave the schedule component token in the final conf file which when parsee by the kernel will not be defined properly, I can attach logs and examples in a few hours |
|
@cujomalainey Yes, please. And also what is ToT? |
@tlauda the sof-dai-playback m4 file defines the schedule comp for the media pipeline to use. So the DAI_ADD def has to be before the media pipeline is added. |
|
@tlauda media pipe definition needs the scheduling component definition (in dai), because of branched pipeline. Dai definition takes only 1 pipeline id as argument (which is the low latency). That's why it should be before media pipe... so is this somehow changed now? |
|
@ranj063 ok you we're before me here :) |
|
@tlauda fyi ToT (top of tree) :) |
|
@cujomalainey @tlauda It seems like a workaroud to me. I will look into the issue to check what goes wrong with the m4 framework. |
|
@xiulipan It isn't a workaround. Media pipeline needs particular DAI as a scheduling component, so it needs to be defined before pipe itself. |
|
@tlauda Got that, thanks for the explanation, then this is m4 limitation. We will need to add this into some WIKI or readme. |
5 participants
The DAI definition needs to come first otherwise the media pipeline with
be parsed incorrectly resulting in a failure to load the topology
Signed-off-by: Curtis Malainey cujomalainey@google.com