Skip to content

cmake: optimization levels #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jajanusz merged 2 commits into from
Nov 8, 2019
Merged

cmake: optimization levels #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c34e2c
kconfig: optimization levels
jajanusz Nov 5, 2019
a222f96
arch: xtensa: use optimization configs
jajanusz Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,40 @@ config INTERRUPT_LEVEL_5

source "src/Kconfig"

choice
prompt "Optimization"
default OPTIMIZE_FOR_PERFORMANCE
help
Controls how compiler should optimize binary.
This config should affect only compiler settings and is
not meant to be used for conditional compilation of code.

config OPTIMIZE_FOR_PERFORMANCE
bool "Optimize for performance"
help
Apply compiler optimizations prioritizing performance.
It means -O2 for GCC or equivalent for other compilers.

config OPTIMIZE_FOR_SIZE
bool "Optimize for size"
help
Apply compiler optimizations prioritizing binary size.
It means -Os for GCC or equivalent for other compilers.

config OPTIMIZE_FOR_DEBUG
bool "Optimize for debug"
help
Apply compiler optimizations prioritizing debugging experience.
It means -Og for GCC or equivalent for other compilers.

config OPTIMIZE_FOR_NONE
bool "Don't optimize"
help
Apply no compiler optimizations.
It means -O0 for GCC or equivalent for other compilers.

endchoice

menu "Debug"

config DEBUG
Expand Down
12 changes: 11 additions & 1 deletion src/arch/xtensa/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@ else()
set(stdlib_flag "-nostdlib")
endif()

if(CONFIG_OPTIMIZE_FOR_PERFORMANCE)
set(optimization_flag "-O2")
elseif(CONFIG_OPTIMIZE_FOR_SIZE)
set(optimization_flag "-Os")
elseif(CONFIG_OPTIMIZE_FOR_DEBUG)
set(optimization_flag "-Og")
elseif(CONFIG_OPTIMIZE_FOR_NONE)
set(optimization_flag "-O0")
endif()

# linker flags
target_link_libraries(sof_options INTERFACE ${stdlib_flag} -Wl,--no-check-sections -ucall_user_start -Wl,-static)

Expand All @@ -77,7 +87,7 @@ target_compile_options(sof_options INTERFACE ${stdlib_flag} -fno-inline-function
# better to have set of default flags and change it only for special cases
# 3) custom function that is used instead of target_sources and sets flags
# for each added source based on file extension
target_compile_options(sof_options INTERFACE $<$<COMPILE_LANGUAGE:C>:-O2 -g -Wall -Werror -Wl,-EL -Wmissing-prototypes -Wpointer-arith -mtext-section-literals>)
target_compile_options(sof_options INTERFACE $<$<COMPILE_LANGUAGE:C>: ${optimization_flag} -g -Wall -Werror -Wl,-EL -Wmissing-prototypes -Wpointer-arith -mtext-section-literals>)

if(BUILD_UNIT_TESTS)
# rest of this file is not needed for unit tests
Expand Down