cmake: trigger olddefconfig on kconfig changes #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are changes made to Kconfig files it's better to run olddefconfig automatically to prevent undesired behaviour, like for example depending on added config that has some default value that is not present because developer didn't run olddefconfig after pulling changes. Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
jajanusz
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
paulstelian97
paulstelian97
approved these changes
Nov 6, 2019
lgirdwood
approved these changes
Nov 6, 2019
Member
|
@jajanusz can you comment on CI, looks like an unrelated false positve |
Contributor
Author
|
@lgirdwood It's random jenkins fail |
Contributor
|
@lgirdwood @jajanusz This is known issue on BSW that kmod reload did not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are changes made to Kconfig files it's better
to run olddefconfig automatically to prevent undesired behaviour,
like for example depending on added config that has some default value
that is not present because developer didn't run olddefconfig
after pulling changes.
Usefull f.e. in case like this: #2054
Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com