Skip to content

Enable BDW topology #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 2 commits into from
Dec 16, 2019
Merged

Enable BDW topology #2095

lgirdwood merged 2 commits into from
Dec 16, 2019

Conversation

@xiulipan
Copy link
Contributor

@xiulipan xiulipan commented Nov 14, 2019

Fix sof-bdw-rt286.tplg load
Add HSW/BDW nocodec topology.

@xiulipan xiulipan mentioned this pull request Nov 14, 2019
Closed
@jajanusz
Copy link
Contributor

jajanusz commented Nov 14, 2019

@xiulipan Is it fix for CI?

@xiulipan
Copy link
Contributor Author

xiulipan commented Nov 14, 2019

@jajanusz This is enable for BDW platform, we are trying to add BDW into CI. But BDW can not pass manually test now

@lgirdwood
Copy link
Member

lgirdwood commented Nov 14, 2019

@zrombel any reason why internal CI builds would fail on unrelated patch ? (Travis build passed)

@zrombel
Copy link

zrombel commented Nov 14, 2019

@lgirdwood looks like QuickBuild issue. Rerunning build.

plbossart
plbossart requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hsw is not supported by SOF, and there are no platforms available. Let's drop it.
See other comments below

tools/topology/CMakeLists.txt Outdated
Copy link
Member

@plbossart plbossart Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support haswell, why bother?

Copy link
Contributor Author

@xiulipan xiulipan Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will remove. So do we need to remove the build for HSW FW as well?

Copy link
Member

@plbossart plbossart Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

tools/topology/sof-hsw-nocodec.m4 Outdated
Copy link
Member

@plbossart plbossart Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do Baytrail and cherrytrail do here?

Copy link
Contributor Author

@xiulipan xiulipan Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart copy paste from the working sof-byt-nocodec.m4, will fix.

tools/topology/sof-hsw-nocodec.m4 Outdated
Copy link
Member

@plbossart plbossart Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget hsw

tools/topology/sof-hsw-nocodec.m4 Outdated
Copy link
Member

@plbossart plbossart Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this only here?

@xiulipan
Copy link
Contributor Author

xiulipan commented Nov 15, 2019

@plbossart updated the nocodec part.
@ranj063 Why we have the dai before media in byt nocodec?
@tlauda Do we need to change the scheduler for BYT/BDW ?

@xiulipan xiulipan mentioned this pull request Nov 15, 2019
Merged
ranj063
ranj063 reviewed Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@ranj063 ranj063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan What does the commit message "No SMP support is on SMP" mean? Please change the wording

@ranj063
Copy link
Collaborator

ranj063 commented Nov 15, 2019

@ranj063 Why we have the dai before media in byt nocodec?

@xiulipan because the media pipeline needs to know the scheduling comp (PIPELINE_PLAYBACK_SCHED_COMP_1) and that is set by DAI_ADD() for pipeline 1

@zrombel
Copy link

zrombel commented Nov 28, 2019

Due to PR#2029 merge and CI bit depth conversion tests changes, this PR require rebase.

@plbossart
Copy link
Member

plbossart commented Dec 4, 2019

@xiulipan can you rebase and resubmit?

@xiulipan
Copy link
Contributor Author

xiulipan commented Dec 5, 2019

@plbossart Sure, will try to fix the BDW FW and rebase tplg first.

@xiulipan
topology: add bdw nocodec topology
2eb6272 
Enable nocodec topology for bdw.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan
Copy link
Contributor Author

xiulipan commented Dec 12, 2019

@plbossart @jajanusz @ranj063 update with bdw-rt5677 topology.
Test with thesofproject/linux#1484 fw and tplg load is good.
Playback is also work with #2188

ranj063
ranj063 reviewed Dec 13, 2019
View reviewed changes
tools/topology/sof-bdw-codec.m4 Outdated
Copy link
Collaborator

@ranj063 ranj063 Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan there is no need to make the virtual widgets conditional at all. As long as they have unique IDs, no harm in just adding all of them

Copy link
Contributor Author

@xiulipan xiulipan Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063 Even if there is no need to add that virtual widgets?

@ranj063
Copy link
Collaborator

ranj063 commented Dec 13, 2019

fix typo in commit message "Add virtual widget"

@xiulipan
topology: fix bdw codec topology
0948efd 
Add support for bdw-rt5677
Fix load issue with bdw codec toplogy issue, no SMP support.
Add virtual widgets.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan xiulipan requested a review from lgirdwood December 16, 2019 02:43
@lgirdwood lgirdwood merged commit aa732a3 into thesofproject:master Dec 16, 2019
@lgirdwood
Copy link
Member

lgirdwood commented Dec 16, 2019

CI usual suspects

@xiulipan xiulipan mentioned this pull request Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranj063 ranj063 ranj063 left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@jajanusz jajanusz Awaiting requested review from jajanusz

@plbossart plbossart Awaiting requested review from plbossart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiulipan @jajanusz @lgirdwood @zrombel @ranj063 @plbossart