[RFC] topology: move volume/switch control naming to upper level #2099
Conversation
juimonen
requested review from
lbetlej,
lgirdwood,
mmaka1,
plbossart,
ranj063 and
xiulipan
as code owners
juimonen
changed the title
|
Due to PR#2029 merge and CI bit depth conversion tests changes, this PR require rebase. |
|
@ranj063 if you have time, can you still clarify what kind of changes you meant? I was not fully getting it... |
|
@lgirdwood I'll check this tomorrow... @ranj063 if you have time to elaborate what was the idea in your proposal with this as I didn't quite get it... |
juimonen
force-pushed
the
dmic_name_fix
branch
from
ec02425 to
70329d7
Compare
juimonen
force-pushed
the
dmic_name_fix
branch
from
70329d7 to
9a89cf5
Compare
|
@ranj063 I modified this now quite heavily, so trying to make it so that you can set explicit pga/control names from pipeline files if you wish to do so.... You think this is going to the right direction? It should be more clear now and I got rid of the messy defines etc. |
|
@lgirdwood yes will do. I need to rebase this also, was doing against old master... |
|
@juimonen sorry for the delay. I have lost track of what I said earlier in this PR. Let me look through your changes today |
juimonen
force-pushed
the
dmic_name_fix
branch
from
9a89cf5 to
3dc8ded
Compare
|
@ranj063 hold on for a while still :) I need to resolve some issues still... |
juimonen
force-pushed
the
dmic_name_fix
branch
from
3dc8ded to
2c6bf1c
Compare
|
@ranjani ok, now should be good for review... |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@plbossart @ranj063 any comments, if not pls merge.
|
SOFCI TEST |
|
@juimonen CI failing due to conflicts |
juimonen
force-pushed
the
dmic_name_fix
branch
from
2c6bf1c to
437ac66
Compare
Currently pga and related mixercontrol have widget naming schemes inside the macro. This is done to help the person writing topologies as pga's are automatically named by concatenating pipeline ids with hard coded names. As pga and mixercontrol define the control name visible in alsamixer we want to allow explicit naming outside the macro call. For example dmic control needs to be "Dmic0 Capture Volume" as this is defined in UCM and used by Pulseaudio. So let the name argument in pga and mixercontrol macros to be the widget name and don't modify it inside the macro. There are still N_PGA and N_CONTROLMIXER macros which can be used to generate the old style control names. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
|
@juimonen still conflicting ? |
juimonen
force-pushed
the
dmic_name_fix
branch
from
437ac66 to
4e5f36e
Compare
|
@lgirdwood yes should read the github conflict messages... now updated |
|
SOFCI TEST |
|
Please resubmit with "main" as PR base branch. |
5 participants
Dmic volume and switch naming was hardcoded into capture eq pipelines,
which introduced problems when creating several instances of those
pipelines. So move the naming defines up 1 level to the topologies
using those pipelines.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com