Skip to content

trace: Add Kconfig options to enable verbose tracing only from certain classes #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akloniex wants to merge 1 commit into from
Closed

trace: Add Kconfig options to enable verbose tracing only from certain classes #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/audio/asrc/asrc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,17 @@
#define trace_asrc(__e, ...) \
trace_event(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define trace_asrc_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)
Copy link
Collaborator

@lyakh lyakh Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I'm actually not in favour of this change (and others like this throughout the patch. The reasons are very simple: (1) it makes it more difficult to grep for these symbols, e.g. if you want to find all uses of TRACE_CLASS_SRC you won't find this any more. Also it makes following symbols in editors more difficult. (2) it makes it look different from the surrounding lines, e.g. the line above, which uses TRACE_CLASS_SRC in full.
If (1) is a trade-off - you win code compactness but you lose clarity, I think (2) is really not good - either convert all of them, or leave them all as is, don't mix them.

Copy link
Collaborator

@paulstelian97 paulstelian97 Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "TRACE_CLASS_SRC" directly will not work correctly as that will be expanded to a number and will break the very idea of this PR, to disable verbose traces for particular classes. Maybe TRACE_CLASS_SRC with some prefix or suffix?

Copy link
Member Author

@akloniex akloniex Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh It was already picked up by @paulstelian97 and explained on other occurence of this change, here: #2133 (comment)

The intermediate macro trace_event_comp, causes premature TRACE_CLASS_* token expansion, which could be solved by quite some dirty work under the hood in trace_event macro family expansions, or (in my opinion) more elegantly, here.
One could argue that greping for TRACE_CLASS_* doesn't make much sense anymore, as we've already wrapped (almost, reaching 100% soon) all traces in their respective trace_* macros.

If you have an idea how to solve token pasting and expansion more elegantly, I'm open for suggestions, but I honestly think that this route is cleaner than appending _ to tokens to prevent their expansion, and then additionally accounting for it in trace-verbose-private.h.

Copy link
Collaborator

@lyakh lyakh Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulstelian97 thanks for the explanation, I see now. But now my question is then: is it really worth it? Is it really worth adding all those levels of macros if we anyway have the trace-verbose-private.h header, which has a bunch of defines for each of the CONFIG_TRACE_VERBOSE_* options? Wouldn't it be much easier and compact to just add

#if CONFIG_TRACE_VERBOSE_xxx
#define trace_asrc_with_ids(comp_ptr, __e, ...) ...
#else
#define trace_asrc_with_ids(...) do {} while (0)
#endif

in every affected file? Most of them would then just involve changing a couple of lines at the top, others, calling generic macros directly from the code, like dai.c, without wrapping them, will need such a define added at the top, which would (arguably) also simplify them?

Copy link
Collaborator

@paulstelian97 paulstelian97 Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh Tbh if we're doing that I'd say having the definition for trace_asrc_with_ids and every other such macro in a common header and make those macros public would be an easy way out. That sure is a large redo of this change and everyone would thus have to use these custom functions instead of the raw trace_event functions to benefit from that disabling.

Also in case we go with that, use the UNUSED macro instead of a do-while-0 loop. It was built specifically for using in disabled traces.

Copy link
Collaborator

@lyakh lyakh Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulstelian97 I'd be fine keeping those defines in respective .c as long as they're used only there. I don't see a need for a common header if all or at least most of them are only used in a single file. However, if sufficiently many of them are or can be used in multiple files, then yes, we could use a common header.


#define tracev_asrc(__e, ...) \
tracev_event(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define tracev_asrc_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)

#define trace_asrc_error(__e, ...) \
trace_error(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define trace_asrc_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)

/* asrc component private data */
struct comp_data {
Expand Down
9 changes: 3 additions & 6 deletions src/audio/dai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,17 @@
#define trace_dai(__e, ...) \
trace_event(TRACE_CLASS_DAI, __e, ##__VA_ARGS__)
#define trace_dai_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_DAI, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(DAI, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_dai(__e, ...) \
tracev_event(TRACE_CLASS_DAI, __e, ##__VA_ARGS__)
#define tracev_dai_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_DAI, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(DAI, comp_ptr, __e, ##__VA_ARGS__)

#define trace_dai_error(__e, ...) \
trace_error(TRACE_CLASS_DAI, __e, ##__VA_ARGS__)
#define trace_dai_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_DAI, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(DAI, comp_ptr, __e, ##__VA_ARGS__)

struct dai_data {
/* local DMA config */
Expand Down
9 changes: 3 additions & 6 deletions src/audio/detect_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,17 @@
#define trace_keyword(__e, ...) \
trace_event(TRACE_CLASS_KEYWORD, __e, ##__VA_ARGS__)
#define trace_keyword_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_KEYWORD, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(KEYWORD, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_keyword(__e, ...) \
tracev_event(TRACE_CLASS_KEYWORD, __e, ##__VA_ARGS__)
#define tracev_keyword_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_KEYWORD, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(KEYWORD, comp_ptr, __e, ##__VA_ARGS__)

#define trace_keyword_error(__e, ...) \
trace_error(TRACE_CLASS_KEYWORD, __e, ##__VA_ARGS__)
#define trace_keyword_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_KEYWORD, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(KEYWORD, comp_ptr, __e, ##__VA_ARGS__)

#define ACTIVATION_DEFAULT_SHIFT 3
#define ACTIVATION_DEFAULT_DIVIDER_S16 0.5
Expand Down
9 changes: 3 additions & 6 deletions src/audio/eq_fir/eq_fir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,16 @@
/* tracing */
#define trace_eq(__e, ...) trace_event(TRACE_CLASS_EQ_FIR, __e, ##__VA_ARGS__)
#define trace_eq_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_EQ_FIR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(EQ_FIR, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_eq(__e, ...) tracev_event(TRACE_CLASS_EQ_FIR, __e, ##__VA_ARGS__)
#define tracev_eq_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_EQ_FIR, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(EQ_FIR, comp_ptr, __e, ##__VA_ARGS__)

#define trace_eq_error(__e, ...) \
trace_error(TRACE_CLASS_EQ_FIR, __e, ##__VA_ARGS__)
#define trace_eq_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_EQ_FIR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(EQ_FIR, comp_ptr, __e, ##__VA_ARGS__)

/* src component private data */
struct comp_data {
Expand Down
9 changes: 3 additions & 6 deletions src/audio/eq_iir/eq_iir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,16 @@
/* tracing */
#define trace_eq(__e, ...) trace_event(TRACE_CLASS_EQ_IIR, __e, ##__VA_ARGS__)
#define trace_eq_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_EQ_IIR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(EQ_IIR, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_eq(__e, ...) tracev_event(TRACE_CLASS_EQ_IIR, __e, ##__VA_ARGS__)
#define tracev_eq_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_EQ_IIR, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(EQ_IIR, comp_ptr, __e, ##__VA_ARGS__)

#define trace_eq_error(__e, ...) \
trace_error(TRACE_CLASS_EQ_IIR, __e, ##__VA_ARGS__)
#define trace_eq_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_EQ_IIR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(EQ_IIR, comp_ptr, __e, ##__VA_ARGS__)

/* IIR component private data */
struct comp_data {
Expand Down
9 changes: 3 additions & 6 deletions src/audio/mixer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,17 @@
#define trace_mixer(__e, ...) \
trace_event(TRACE_CLASS_MIXER, __e, ##__VA_ARGS__)
#define trace_mixer_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_MIXER, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(MIXER, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_mixer(__e, ...) \
tracev_event(TRACE_CLASS_MIXER, __e, ##__VA_ARGS__)
#define tracev_mixer_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_MIXER, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(MIXER, comp_ptr, __e, ##__VA_ARGS__)

#define trace_mixer_error(__e, ...) \
trace_error(TRACE_CLASS_MIXER, __e, ##__VA_ARGS__)
#define trace_mixer_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_MIXER, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(MIXER, comp_ptr, __e, ##__VA_ARGS__)

/* mixer component private data */
struct mixer_data {
Expand Down
9 changes: 3 additions & 6 deletions src/audio/src/src.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,17 @@
#define trace_src(__e, ...) \
trace_event(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define trace_src_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_src(__e, ...) \
tracev_event(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define tracev_src_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)

#define trace_src_error(__e, ...) \
trace_error(TRACE_CLASS_SRC, __e, ##__VA_ARGS__)
#define trace_src_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_SRC, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(SRC, comp_ptr, __e, ##__VA_ARGS__)

/* The FIR maximum lengths are per channel so need to multiply them */
#define MAX_FIR_DELAY_SIZE_XNCH (PLATFORM_MAX_CHANNELS * MAX_FIR_DELAY_SIZE)
Expand Down
9 changes: 3 additions & 6 deletions src/audio/switch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,17 @@
#define trace_switch(__e, ...) \
trace_event(TRACE_CLASS_SWITCH, __e, ##__VA_ARGS__)
#define trace_switch_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_SWITCH, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(SWITCH, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_switch(__e, ...) \
tracev_event(TRACE_CLASS_SWITCH, __e, ##__VA_ARGS__)
#define tracev_switch_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_SWITCH, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(SWITCH, comp_ptr, __e, ##__VA_ARGS__)

#define trace_switch_error(__e, ...) \
trace_error(TRACE_CLASS_SWITCH, __e, ##__VA_ARGS__)
#define trace_switch_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_SWITCH, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(SWITCH, comp_ptr, __e, ##__VA_ARGS__)


static struct comp_dev *switch_new(struct sof_ipc_comp *comp)
Expand Down
9 changes: 3 additions & 6 deletions src/audio/tone.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,17 @@
#define trace_tone(__e, ...) \
trace_event(TRACE_CLASS_TONE, __e, ##__VA_ARGS__)
#define trace_tone_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_TONE, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(TONE, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_tone(__e, ...) \
tracev_event(TRACE_CLASS_TONE, __e, ##__VA_ARGS__)
#define tracev_tone_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_TONE, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(TONE, comp_ptr, __e, ##__VA_ARGS__)

#define trace_tone_error(__e, ...) \
trace_error(TRACE_CLASS_TONE, __e, ##__VA_ARGS__)
#define trace_tone_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_TONE, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(TONE, comp_ptr, __e, ##__VA_ARGS__)

/* Convert float frequency in Hz to Q16.16 fractional format */
#define TONE_FREQ(f) Q_CONVERT_FLOAT(f, 16)
Expand Down
9 changes: 3 additions & 6 deletions src/include/sof/audio/component.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,17 @@ struct dai_hw_params;
#define trace_comp(__e, ...) \
trace_event(TRACE_CLASS_COMP, __e, ##__VA_ARGS__)
#define trace_comp_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_COMP, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(COMP, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_comp(__e, ...) \
tracev_event(TRACE_CLASS_COMP, __e, ##__VA_ARGS__)
#define tracev_comp_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_COMP, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(COMP, comp_ptr, __e, ##__VA_ARGS__)

#define trace_comp_error(__e, ...) \
trace_error(TRACE_CLASS_COMP, __e, ##__VA_ARGS__)
#define trace_comp_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_COMP, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(COMP, comp_ptr, __e, ##__VA_ARGS__)
/** @}*/

/* \brief Type of endpoint this component is connected to in a pipeline */
Expand Down
9 changes: 3 additions & 6 deletions src/include/sof/audio/kpb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,16 @@ struct comp_buffer;
/* KPB tracing */
#define trace_kpb(__e, ...) trace_event(TRACE_CLASS_KPB, __e, ##__VA_ARGS__)
#define trace_kpb_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_KPB, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(KPB, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_kpb(__e, ...) tracev_event(TRACE_CLASS_KPB, __e, ##__VA_ARGS__)
#define tracev_kpb_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_KPB, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(KPB, comp_ptr, __e, ##__VA_ARGS__)

#define trace_kpb_error(__e, ...) trace_error(TRACE_CLASS_KPB, __e, \
##__VA_ARGS__)
#define trace_kpb_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_KPB, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(KPB, comp_ptr, __e, ##__VA_ARGS__)

/* KPB internal defines */
#define KPB_MAX_BUFF_TIME 2100 /**< time of buffering in miliseconds */
Expand Down
9 changes: 3 additions & 6 deletions src/include/sof/audio/mux.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,17 @@ struct comp_dev;
/* tracing */
#define trace_mux(__e, ...) trace_event(TRACE_CLASS_MUX, __e, ##__VA_ARGS__)
#define trace_mux_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_MUX, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(MUX, comp_ptr, __e, ##__VA_ARGS__)

#define tracev_mux(__e, ...) \
tracev_event(TRACE_CLASS_MUX, __e, ##__VA_ARGS__)
#define tracev_mux_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_MUX, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(MUX, comp_ptr, __e, ##__VA_ARGS__)

#define trace_mux_error(__e, ...) \
trace_error(TRACE_CLASS_MUX, __e, ##__VA_ARGS__)
#define trace_mux_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_MUX, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(MUX, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Supported streams count. */
#define MUX_MAX_STREAMS 4
Expand Down
9 changes: 3 additions & 6 deletions src/include/sof/audio/selector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,19 @@ struct comp_dev;
#define trace_selector(__e, ...) \
trace_event(TRACE_CLASS_SELECTOR, __e, ##__VA_ARGS__)
#define trace_selector_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_SELECTOR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(SELECTOR, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Selector trace verbose function. */
#define tracev_selector(__e, ...) \
tracev_event(TRACE_CLASS_SELECTOR, __e, ##__VA_ARGS__)
#define tracev_selector_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_SELECTOR, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(SELECTOR, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Selector trace error function. */
#define trace_selector_error(__e, ...) \
trace_error(TRACE_CLASS_SELECTOR, __e, ##__VA_ARGS__)
#define trace_selector_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_SELECTOR, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(SELECTOR, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Supported channel count on input. */
#define SEL_SOURCE_2CH 2
Expand Down
9 changes: 3 additions & 6 deletions src/include/sof/audio/volume.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,19 @@ struct sof_ipc_ctrl_value_chan;
#define trace_volume(__e, ...) \
trace_event(TRACE_CLASS_VOLUME, __e, ##__VA_ARGS__)
#define trace_volume_with_ids(comp_ptr, __e, ...) \
trace_event_comp(TRACE_CLASS_VOLUME, comp_ptr, \
__e, ##__VA_ARGS__)
trace_event_comp(VOLUME, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Volume trace value function. */
#define tracev_volume(__e, ...) \
tracev_event(TRACE_CLASS_VOLUME, __e, ##__VA_ARGS__)
#define tracev_volume_with_ids(comp_ptr, __e, ...) \
tracev_event_comp(TRACE_CLASS_VOLUME, comp_ptr, \
__e, ##__VA_ARGS__)
tracev_event_comp(VOLUME, comp_ptr, __e, ##__VA_ARGS__)

/** \brief Volume trace error function. */
#define trace_volume_error(__e, ...) \
trace_error(TRACE_CLASS_VOLUME, __e, ##__VA_ARGS__)
#define trace_volume_error_with_ids(comp_ptr, __e, ...) \
trace_error_comp(TRACE_CLASS_VOLUME, comp_ptr, \
__e, ##__VA_ARGS__)
trace_error_comp(VOLUME, comp_ptr, __e, ##__VA_ARGS__)

//** \brief Volume gain Qx.y integer x number of bits including sign bit. */
#define VOL_QXY_X 8
Expand Down
Loading