build: disable asrc xcc defconfig for byt cht #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to disable asrc support for BYT and CHT for xcc build. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
jajanusz
approved these changes
Dec 9, 2019
Contributor
lyakh
approved these changes
Dec 9, 2019
jajanusz
approved these changes
Dec 9, 2019
Collaborator
|
In my view the idea has been in generic builds to enable everything by default (make sure the features do not break due to other development) and disable only features those are not feasible for a platform. |
Collaborator
|
@xiulipan Should the "CONFIG_COMP_ASRC=n" be done for HSW and BDW too? When I did the ASRC PR I didn't know that xcc build uses separate defconfig files. |
Contributor
Author
|
@singalsu For bdw/hsw, they share the same defconfig. |
Collaborator
|
Thanks for explanation @xiulipan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to disable asrc support for BYT and CHT for xcc build.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com
Fix missed change from #1908 to #2024 for xcc build