Skip to content

ipc: increase msg max size #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abonislawski wants to merge 1 commit into from
Closed

ipc: increase msg max size #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/include/ipc/header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
#define SOF_IPC_MESSAGE_ID(x) ((x) & 0xffff)

/** Maximum message size for mailbox Tx/Rx */
#define SOF_IPC_MSG_MAX_SIZE 384
#define SOF_IPC_MSG_MAX_SIZE 768
Copy link
Member

@lgirdwood lgirdwood Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski my understanding after recent discussions is that we are moving to 2kB.

Copy link
Contributor

@jajanusz jajanusz Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood To move to 2kB we have to rework how msgs are allocated. @abonislawski will work on that, but for now we would like to use as much as we can without these changes.

Copy link
Member Author

@abonislawski abonislawski Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood just like @jajanusz said, please merge

Copy link
Member

@plbossart plbossart Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood To move to 2kB we have to rework how msgs are allocated. @abonislawski will work on that, but for now we would like to use as much as we can without these changes.

can we quantify the work needed to support 2KB IPC messages? If we can have ONE ABI change it's less work for me, and less confusion for everyone.

Copy link
Member Author

@abonislawski abonislawski Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart hardly to say but atm Im busy with other tasks

Copy link
Contributor

@jajanusz jajanusz Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart It's not 5-minutes-task. Msg allocation and handling code would need to be reworked and we have more urgent tasks now. We want to increase it to 768 atm, cos without it we stall another feature. I know it's inconvenient for you, but we can't help much with that now. We would greatly appreciate your help with approving this one.

Copy link
Member

@plbossart plbossart Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm, what happens if I don't? The mux would be stalled, but what is the impact? Put differently, who needs the mux support from the kernel level in the coming weeks?


/** @} */

Expand Down
2 changes: 1 addition & 1 deletion src/platform/cannonlake/include/platform/lib/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@
#define HEAP_BUFFER_BLOCK_SIZE 0x180
#define HEAP_BUFFER_COUNT (HEAP_BUFFER_SIZE / HEAP_BUFFER_BLOCK_SIZE)

#define HEAP_SYSTEM_M_SIZE 0x8000 /* heap master core size */
#define HEAP_SYSTEM_M_SIZE 0x9000 /* heap master core size */
#define HEAP_SYSTEM_S_SIZE 0x6000 /* heap slave core size */

#define HEAP_SYSTEM_T_SIZE \
Expand Down
2 changes: 1 addition & 1 deletion src/platform/haswell/include/platform/lib/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void platform_init_memmap(void);
#define SOF_DATA_SIZE 0xD000

#define HEAP_SYSTEM_BASE (DRAM0_BASE + SOF_DATA_SIZE)
#define HEAP_SYSTEM_SIZE 0x4000
#define HEAP_SYSTEM_SIZE 0x5000

#define HEAP_SYSTEM_0_BASE HEAP_SYSTEM_BASE

Expand Down