Skip to content

eq_fir/irr: refine eq_fir/iir verify() functions #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 4 commits into from
Feb 23, 2020
Merged

eq_fir/irr: refine eq_fir/iir verify() functions #2414

lgirdwood merged 4 commits into from
Feb 23, 2020

Conversation

@bkokoszx
Copy link
Collaborator

@bkokoszx bkokoszx commented Feb 20, 2020

This commit refines eq_fir/irr verify() functions:

  1. eq_fir component is not able to change stream format,
    so we should invoke comp_verify_function() with flag
    equal to 0.
  2. In eq_iir component we should check whether we can
    support frame_fmt conversion due to source and sink
    buffer frame_fmt's. If not, we should overwrite sink (playback)
    and source (capture) with pcm frame_fmt and not make any
    conversion (sink and source frame_fmt will be equal).

Fixes #2401

@bkokoszx
eq_iir: remove unnecessary code in prepare() function
39cfae5 
We do not have to rewrite source/sink frame_fmt. It has been set
in eq_iir_verify_params() function.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx
eq_fir: remove unnecessary code in prepare() function
b310299 
We do not have to rewrite source/sink frame_fmt. It has been
set in eq_fir_verify_params() function.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx bkokoszx requested a review from singalsu as a code owner February 20, 2020 14:37
@bkokoszx
eq_fir: refine eq_fir_verify_params() function
9ead97a 
eq_fir component is not able to change stream format, so we
should invoke comp_verify_function() with flag equal to 0.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx bkokoszx force-pushed the fix-eq-verify-function branch from ddc7755 to f37ebb5 Compare February 20, 2020 14:38
@bkokoszx bkokoszx mentioned this pull request Feb 20, 2020
Closed
@singalsu
Copy link
Collaborator

singalsu commented Feb 20, 2020 •
edited
Loading

I have a question to decide how important is it to preserve format conversion capability in IIR. If we have pipeline like this

DAI (DMIC, 32 bit) --> IIR ---> host (16 bit)

Where would the conversion from 32 bits to 16 bits happen if we would remove the capability from IIR?

If DAI would convert to 16 bits and IIR would run in 16 -> 16 bits mode the quality would not be as good. I made the conversion capability into IIR to be able to get higher quality 16 bit output from DMIC than bare-HW can provide.

Also thanks for the fix! I'll review tomorrow.

lgirdwood
lgirdwood approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu wont merge until you are happy.

@bkokoszx
Copy link
Collaborator Author

bkokoszx commented Feb 21, 2020

@singalsu
Thanks, your comment helped me to find little issue (PR #2421).
Answering your question (in FW with new PR #2421) it will depend how we will create DAI component. If we create DAI component with frame_fmt equal to 32 format in struct sof_ipc_comp_config, conversion will happen on IIR component, otherwise if we create DAI component with 16 format, conversion will happen on DAI.

@singalsu
Copy link
Collaborator

singalsu commented Feb 21, 2020

Thanks for explanation, then it makes sense to keep the capability.

@lgirdwood
Copy link
Member

lgirdwood commented Feb 21, 2020

@bkokoszx can you check internal CI. Seems to be down.

@singalsu singalsu mentioned this pull request Feb 21, 2020
Merged
@bkokoszx
eq_iir: add supported formats check in verify function
650e166 
We should check whether we can support frame_fmt conversion
due to source and sink buffer frame_fmt's. If not, we should
overwrite sink (playback) and source (capture) with pcm
frame_fmt and not make any conversion (sink and source
frame_fmt will be equal).

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx bkokoszx force-pushed the fix-eq-verify-function branch from f37ebb5 to 650e166 Compare February 21, 2020 13:38
@lgirdwood lgirdwood merged commit 1d273c3 into thesofproject:master Feb 23, 2020
@bkokoszx bkokoszx deleted the fix-eq-verify-function branch March 10, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulstelian97 paulstelian97 paulstelian97 approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@singalsu singalsu singalsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][APL][PCM512X]EQ-test occur ipc error for 0x60010000 size 20

4 participants

@bkokoszx @singalsu @lgirdwood @paulstelian97