Skip to content

Conversation

@mmaka1
Copy link

@mmaka1 mmaka1 commented Mar 10, 2020

Removed the diagram duplicated in sof-docs, moved set_state
notes from sof-docs to the header to make it easier accesible
for component developers and added notes for infrastructure
developers to remember about the sof-docs updates.

Signed-off-by: Marcin Maka marcin.maka@linux.intel.com

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PR for sof docs ?

@mmaka1
Copy link
Author

mmaka1 commented Mar 10, 2020

@lgirdwood Yes, this one: thesofproject/sof-docs#194 with updated state diagram.

Removed the diagram duplicated in sof-docs, moved set_state
notes from sof-docs to the header to make it easier accesible
for component developers and added notes for infrastructure
developers to remember about the sof-docs updates.

Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
@lgirdwood
Copy link
Member

@xiulipan @fredoh9 any ideas why logger is failing here ?

@xiulipan
Copy link
Contributor

@lgirdwood Please see #2507 and #2522

@lgirdwood lgirdwood merged commit 366aa67 into thesofproject:master Mar 12, 2020
@mmaka1 mmaka1 deleted the comp-api-fix branch March 13, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants